[AZINTS-4139] Specify max client secret TTL when creating app registration#67
Merged
Conversation
benjjs
reviewed
Oct 31, 2025
| # Try setting the TTL to the max of 2 years. | ||
| result = execute_json(cmd.param("--years", f"{APP_REGISTRATION_CLIENT_SECRET_TTL_YEARS}")) | ||
| # If it fails, just use the default TTL. | ||
| except Exception: |
Collaborator
Author
There was a problem hiding this comment.
Linters tend to complain about that, also that excepts BaseException which includes weird stuff like StopIteration (iterator exit signal) etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expiring secrets are a huge pain for everyone. Let's default this to the max TTL of 2 years rather than the default of 1 year. If the customer cares enough to want a shorter secret TTL, they can create a new secret and update it in the UI after creation.
Note: it is possible to set policies to reduce the max TTL of client secrets. We should determine the behavior of this command (with and without specifying
--years) when such policies are in place and follow-on to handle this error, most likely by retrying without specifying--years.EDIT: I just went ahead and did a generic
except/retry without the--yearsparam.