Report disconnects separately#74
Merged
Merged
Conversation
gpalmz
approved these changes
Nov 3, 2025
benjjs
force-pushed
the
benjamin.johnsonstaub/report-disconnect-status
branch
from
98e6fbd to
7150574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to treat disconnects, either manual or timeouts, separately from errors.
Summary
Report a new "DISCONNECTED" status instead of ERROR when we time out or when the user SIGINTS their script. The corresponding changes to the ui are here: https://github.com/DataDog/web-ui/pull/244848.
This should not be merged until the web-ui changes are live in all DCs. Otherwise, the UI will not know what to do with this status and disconnects will cause silent failures.
Testing
Open onboarding flow in sandbox, run against local shell. Try disconnecting:
It shows as a disconnect and not an error.