Fix management group fetch permission error#79
Merged
benjjs merged 1 commit intoNov 4, 2025
Merged
Conversation
agulen
approved these changes
Nov 4, 2025
gpalmz
approved these changes
Nov 4, 2025
benjjs
force-pushed
the
benjamin.johnsonstaub/azints-4181/allow-missing-management-groups
branch
from
1694274 to
8809ecd
Compare
Base automatically changed from
benjamin.johnsonstaub/azints-4124/guard-against-manual-copy-script
to
main
November 4, 2025 21:26
benjjs
force-pushed
the
benjamin.johnsonstaub/azints-4181/allow-missing-management-groups
branch
from
8809ecd to
143cc7a
Compare
benjjs
deleted the
benjamin.johnsonstaub/azints-4181/allow-missing-management-groups
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We were seeing some users get user actionable errors due to lacking permissions to see management groups. This shouldn't actually be blocking, we already have a good interface to communicate that they lack permissions to see any management groups if that was something they were expecting,
Summary
When I switched the quickstart script to use AzCmd, we started getting the more informative
AccessErrorwhen the user lacked this permission, but we were still catching onlyRuntimeError. I've simply swapped them out. There is some argument to allow both error types or even all, but AccessError is the only one we actually expect. If we are seeing other error types here it probably does mean that something is actually wrong.Testing
Connect onboarding flow to local shell, spoof an access error in list management groups, check the UI. No error, and when we click on the management groups tab we see the expected result
