Skip to content

AGTMETRICS-489 Make serializer bit more robust#311

Merged
vickenty merged 2 commits into
masterfrom
vickenty/skc
Jun 3, 2026
Merged

AGTMETRICS-489 Make serializer bit more robust#311
vickenty merged 2 commits into
masterfrom
vickenty/skc

Conversation

@vickenty
Copy link
Copy Markdown
Contributor

@vickenty vickenty commented May 1, 2026

This fixes two minor issues:

  • Don't encode metrics without points.
  • If SketchMetric#addPoint throws (which it is likely to do), add method to clear partially filled buffers so that the payload can still be finished.

vickenty added 2 commits May 1, 2026 19:28
@vickenty
Don't encode metrics without points
1b6bed6
@vickenty
Expose a rollback mechanism for metrics
1df1be4 
Allow payload to be completed and sent if SketchMetric#addPoint throws.
@vickenty vickenty changed the title Make serializer bit more robust AGTMETRICS-489 Make serializer bit more robust May 13, 2026
Base automatically changed from vickenty/ske to master May 22, 2026 12:51
@vickenty vickenty marked this pull request as ready for review June 2, 2026 09:48
@vickenty vickenty requested a review from a team as a code owner June 2, 2026 09:48
@vickenty vickenty merged commit 1e6d329 into master Jun 3, 2026
2 of 3 checks passed
@vickenty vickenty deleted the vickenty/skc branch June 3, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atanzu atanzu atanzu approved these changes

Assignees

No one assigned

Labels

mergequeue-status: rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vickenty @atanzu