Fix remaining dead code and stale comments in stackwalker refactor#455
Open
Fix remaining dead code and stale comments in stackwalker refactor#455
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||
CI Test ResultsRun: #24182253808 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-04-09 10:15:40 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Fixes three leftover issues from the stackwalker refactor (#451):
Profiler::_runtime_stubs(CodeCache): the field was missed when_stubs_lock,_call_stub_begin, and_call_stub_endwere removed. All stub routing moved toJitCodeCachein Refactor stackwalker #451;profiler.cpphas zero remaining references to this field.alignascomment onProfilerthat still listed_stubs_lockafter its removal.HotspotSupport::checkFault: "have not been initialized" → "has not been initialized".Motivation:
Follow-up from code review of #451. These were identified in the review but not addressed in the main PR's code-review commit.
Additional Notes:
Depends on #451.
How to test the change?:
No behaviour change — dead field removal and comment fixes only. Existing tests cover the surrounding code.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!
🤖 Generated with Claude Sonnet on behalf of @jbachorik