Skip to content

Do not fail if requested cstack is not supported #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbachorik merged 1 commit into from
Dec 7, 2023
Merged

Do not fail if requested cstack is not supported #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ddprof-lib/src/main/cpp/profiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,9 +1041,11 @@ Error Profiler::start(Arguments& args, bool reset) {
_wall_engine = selectWallEngine(args);
_cstack = args._cstack;
if (_cstack == CSTACK_DWARF && !DWARF_SUPPORTED) {
return Error("DWARF unwinding is not supported on this platform");
_cstack = CSTACK_NO;
Log::warn("DWARF unwinding is not supported on this platform. Defaulting to no native call stack unwinding.");
} else if (_cstack == CSTACK_LBR && _cpu_engine != &perf_events) {
return Error("Branch stack is supported only with PMU events");
_cstack = CSTACK_NO;
Log::warn("Branch stack is supported only with PMU events");
}

// Kernel symbols are useful only for perf_events without --all-user
Expand Down