Skip to content

fix(ci): exclude publish-benchmark-gh-pages from schedule pipelines#557

Merged
jbachorik merged 1 commit into
mainfrom
fix/reliability-pipeline-benchmark-needs
May 29, 2026
Merged

fix(ci): exclude publish-benchmark-gh-pages from schedule pipelines#557
jbachorik merged 1 commit into
mainfrom
fix/reliability-pipeline-benchmark-needs

Conversation

@jbachorik
Copy link
Copy Markdown
Collaborator

What does this PR do?:
Adds a when: never rule for $CI_PIPELINE_SOURCE == "schedule" to the publish-benchmark-gh-pages job.

Motivation:
The reliability (scheduled) pipeline was failing at validation time with errors like:

'publish-benchmark-gh-pages' job needs 'benchmarks-candidate-amd64: [cpu]' job, but it does not exist in the pipeline.

The benchmarks-candidate-amd64/aarch64 jobs have no schedule rule so they never run in scheduled pipelines. The publish-benchmark-gh-pages job, however, had no schedule exclusion — causing GitLab to reject the pipeline because its needs dependencies were absent.

Additional Notes:
The benchmark jobs intentionally don't run on schedule pipelines (they run on trigger/pipeline/web/push sources). This fix aligns publish-benchmark-gh-pages with that constraint.

How to test the change?:
Trigger a scheduled (reliability) pipeline and verify it no longer errors at validation. Trigger a normal pipeline on main and verify publish-benchmark-gh-pages still runs.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jbachorik jbachorik marked this pull request as ready for review May 29, 2026 06:16
@jbachorik jbachorik requested a review from a team as a code owner May 29, 2026 06:16
@jbachorik jbachorik merged commit 45e1535 into main May 29, 2026
40 of 68 checks passed
@jbachorik jbachorik deleted the fix/reliability-pipeline-benchmark-needs branch May 29, 2026 06:17
@github-actions github-actions Bot added this to the 1.44.0 milestone May 29, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 29, 2026

CI Test Results

Run: #26621524317 | Commit: 2c2156a | Duration: 12m 18s (longest job)

All 32 test jobs passed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - - -
8-ibm - - -
8-j9 - -
8-librca - -
8-orcl - - -
11 - - -
11-j9 - -
11-librca - -
17 - -
17-graal - -
17-j9 - -
17-librca - -
21 - -
21-graal - -
21-librca - -
25 - -
25-graal - -
25-librca - -

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-05-29 06:33:42 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant