Skip to content

add operation to trace root event#59

Merged
richardstartin merged 1 commit into
mainfrom
rgs/root-operation
Jan 11, 2024
Merged

add operation to trace root event#59
richardstartin merged 1 commit into
mainfrom
rgs/root-operation

Conversation

@richardstartin
Copy link
Copy Markdown
Contributor

Adds the operation of the root span. Also disables the rust demangler unit test on MacOS because it appears to be failing locally. I will revisit this in a different PR to figure out why.

Motivation:
This allows a new kind of resource utilisation metric to be reported.

Additional Notes:

How to test the change?:

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 10, 2024

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Warnings (2)

Style Violations (154)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 10, 2024

🔧 Report generated by pr-comment-scanbuild

Scan-Build Report

User:runner@fv-az1019-714
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 clean all
Clang Version:Ubuntu clang version 14.0.0-1ubuntu1.1
Date:Wed Jan 10 11:51:08 2024

Bug Summary

Bug TypeQuantityDisplay?
All Bugs6
Logic error
Assigned value is garbage or undefined1
Dereference of null pointer2
Result of operation is garbage or undefined1
Unused code
Dead initialization1
Dead nested assignment1

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Logic errorAssigned value is garbage or undefineddwarf.cppparseInstructions23120
Unused codeDead initializationlivenessTracker.cppcleanup_table451
Unused codeDead nested assignmentvmStructs.cppcheckNativeBinding6951
Logic errorDereference of null pointerflightRecorder.cppflush14098
Logic errorDereference of null pointersafeAccess.hload3518
Logic errorResult of operation is garbage or undefineddwarf.hgetSLeb12325

@richardstartin richardstartin merged commit 17dfa3e into main Jan 11, 2024
@github-actions github-actions Bot added this to the 0.95.0 milestone Jan 11, 2024
@richardstartin richardstartin deleted the rgs/root-operation branch January 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant