feat(ai): Adding AGENTS.md/CLAUDE.md and new skill to create GC tests (including adding missing GC tests).#608
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomasterfrom Apr 10, 2026
Conversation
Add TestGCMetrics tests for two collectors present in new-gc-default-jmx-metrics.yaml that lacked coverage: - UseSerialGC: asserts Copy (minor) and MarkSweepCompact (major) - UseShenandoahGC: asserts Shenandoah Cycles (major) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a reusable Claude Code skill for generating integration tests in TestGCMetrics.java when new GC collectors are added to new-gc-default-jmx-metrics.yaml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vickenty
approved these changes
Apr 10, 2026
Contributor
vickenty
left a comment
vickenty
left a comment
There was a problem hiding this comment.
I wouldn't expect code changes from a PR with this title, even if it is just the tests. Would it make sense to update PR to highlight actual code changes as well?
Contributor
Author
|
@vickenty Good catch. Will update the title to reflect I added some new tests. |
carlosroman
changed the title
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some coding agent files.
Used the new skill
add-gc-testto add missing GC tests.