Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
blt
force-pushed
the
blt/update_bollard_dependency
branch
from
6a2c2c2 to
ee9f006
Compare
blt
force-pushed
the
blt/update_bollard_dependency
branch
from
ee9f006 to
409ba22
Compare
This commit is an attempt to demonstrate the claude CLI tool for the purposes of mostly mechanical dependency upgrades. This kind of work is a non-trivial effort sink for lading and other SMP projects, it'd be swell if a machine could do it. I find the result here satisfying. I acted as critical reviewer, claude as implementor. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/update_bollard_dependency
branch
from
409ba22 to
87793ed
Compare
GeorgeHahn
reviewed
Jun 3, 2025
|
|
||
| let pid: i64 = loop { | ||
| if let Ok(container) = docker.inspect_container(&config.name, None).await { | ||
| let inspect_options = InspectContainerOptionsBuilder::default().build(); |
Contributor
There was a problem hiding this comment.
This looks unnecessary - could the second parameter below stay None?
Collaborator
Author
There was a problem hiding this comment.
I think that it could. I dinged this myself at first and then after further consideration felt that it added more detail I found useful while skimming.
GeorgeHahn
reviewed
Jun 3, 2025
| fn to_container_config<'a>(&'a self, full_image: &'a str) -> ContainerConfig<&'a str> { | ||
| ContainerConfig { | ||
| image: Some(full_image), | ||
| fn to_container_config(&self, full_image: &str) -> ContainerCreateBody { |
Contributor
There was a problem hiding this comment.
Note, changes in this fn look unrelated, but I'm not sad about them
GeorgeHahn
reviewed
Jun 3, 2025
| _ = liveness_interval.tick() => { | ||
| for container in &containers { | ||
| if let Some(state) = docker.inspect_container(&container.id, None).await?.state { | ||
| let inspect_options = InspectContainerOptionsBuilder::default().build(); |
Contributor
There was a problem hiding this comment.
Nit, building a default value (same as below)
GeorgeHahn
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit is an attempt to demonstrate the claude CLI tool for
the purposes of mostly mechanical dependency upgrades. This kind
of work is a non-trivial effort sink for lading and other SMP
projects, it'd be swell if a machine could do it.
I find the result here satisfying. I acted as critical reviewer,
claude as implementor.