refactor(lading): annotate intentional-panic file_gen sites#1898
Draft
goxberry wants to merge 1 commit into
Draft
refactor(lading): annotate intentional-panic file_gen sites#1898goxberry wants to merge 1 commit into
goxberry wants to merge 1 commit into
Conversation
Attach fn-level #[expect(clippy::expect_used, reason = "...")] to the
logrotate generator and the logrotate_fs FUSE filesystem callbacks. The
FUSE state mutex is held only briefly inside each callback so a poisoned
mutex is unrecoverable; the model itself maintains the parent/file-type/
name invariants used inside `readdir`.
- generator/file_gen/logrotate.rs::Child::spin (non-empty names invariant)
- generator/file_gen/logrotate_fs.rs::Server::new (FIXME: fuse_mount2 spawn)
- generator/file_gen/logrotate_fs.rs::{lookup,getattr,read,release,readdir,open}
- generator/file_gen/logrotate_fs/model.rs::advance_time_inner
- generator/file_gen/logrotate_fs/model.rs::read
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced May 23, 2026
Contributor
Author
This was referenced May 23, 2026
|
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Annotate intentional-panic
.expect()sites ingenerator/file_gen/*with fn-level#[expect(clippy::expect_used, reason = "...")]. These are FUSE/logrotate-fs entry points where panicking on an internal invariant violation is the appropriate failure mode for a load-generation harness.Sites annotated:
Stacked on #1897. Part of the broader push toward enforcing
clippy::expect_used = "deny"workspace-wide.Test plan