Skip to content

Add version pin comment for dd_internal_authentication#235

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomasterfrom
maperu/pinDdAuth
Mar 4, 2026
Merged

Add version pin comment for dd_internal_authentication#235
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomasterfrom
maperu/pinDdAuth

Conversation

@maperu
Copy link
Copy Markdown

@maperu maperu commented Mar 3, 2026

Adds a comment noting that dd_internal_authentication version must match the COA wheel's requires in dd-source BUILD.bazel. Once the companion dd-source PR merges and COA 0.1.29 is published, pip will enforce the version match at install time.

Companion dd-source PR: https://github.com/DataDog/dd-source/pull/373405

@maperu maperu force-pushed the maperu/pinDdAuth branch 2 times, most recently from 8427c00 to 3bde6eb Compare March 3, 2026 18:10
@maperu
Add version pin comment for dd_internal_authentication
101f14e 
The version must match the COA wheel's requires in dd-source BUILD.bazel.
Both need to be updated together when bumping.
@maperu maperu force-pushed the maperu/pinDdAuth branch from b95a574 to 101f14e Compare March 3, 2026 18:13
@maperu maperu marked this pull request as ready for review March 3, 2026 21:19
@maperu maperu requested review from a team as code owners March 3, 2026 21:19
@maperu
Copy link
Copy Markdown
Author

maperu commented Mar 3, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 3, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-03 22:13:37 UTC ℹ️ Start processing command /merge

2026-03-03 22:13:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).

2026-03-03 22:28:45 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
Details

Error: PUT https://api.github.com/repos/DataDog/lemur/pulls/235/merge: 405 2 of 2 required status checks are expected. [] (Request ID: 7F4D:317CFE:415F44:115CDA7:69A76096)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 50, startedEventID: 51, identity: 1@github-worker-65b5464658-msg9k@): PUT https://api.github.com/repos/DataDog/lemur/pulls/235/merge: 405 2 of 2 required status checks are expected. [] (Request ID: 7F4D:317CFE:415F44:115CDA7:69A76096) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/lemur/pulls/235/merge: 405 2 of 2 required status checks are expected. [] (type: ErrorResponse, retryable: true)

@maperu
Copy link
Copy Markdown
Author

maperu commented Mar 4, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 4, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-04 02:32:06 UTC ℹ️ Start processing command /merge

2026-03-04 02:32:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).

2026-03-04 02:52:10 UTC 🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
Details

Error: PUT https://api.github.com/repos/DataDog/lemur/pulls/235/merge: 405 2 of 2 required status checks are expected. [] (Request ID: 33CF:31B988:1C5732C:7878035:69A79E53)

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 50, startedEventID: 51, identity: 1@github-worker-65b5464658-hzxvr@): PUT https://api.github.com/repos/DataDog/lemur/pulls/235/merge: 405 2 of 2 required status checks are expected. [] (Request ID: 33CF:31B988:1C5732C:7878035:69A79E53) (type: GitFailure, retryable: false): PUT https://api.github.com/repos/DataDog/lemur/pulls/235/merge: 405 2 of 2 required status checks are expected. [] (type: ErrorResponse, retryable: true)

@maperu
Copy link
Copy Markdown
Author

maperu commented Mar 4, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 4, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-04 03:04:27 UTC ℹ️ Start processing command /merge

2026-03-04 03:04:31 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).

2026-03-04 03:22:31 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 4ec6047 into master Mar 4, 2026
10 checks passed
evan-datadog pushed a commit that referenced this pull request Mar 4, 2026
@maperu @evan-datadog
Add version pin comment for dd_internal_authentication (#235)
7d4f20a 
Add version pin comment for dd_internal_authentication

The version must match the COA wheel's requires in dd-source BUILD.bazel.
Both need to be updated together when bumping.

Refine comment for dd_internal_authentication version

Updated comment for dd_internal_authentication package.

Retrigger CI after 0.1.29 wheel published

Pin pyjwt to 2.10.1, 2.11.0 breaks Vault OIDC login

Remove unnecessary pyjwt pin, login issue was missing vault group

Merge branch 'master' into maperu/pinDdAuth

Co-authored-by: maxime.perusse <maxime.perusse@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evan-datadog evan-datadog evan-datadog approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maperu @evan-datadog