Conversation
Source syncs are heavy operations. Dispatching all 20+ at once floods the celery queue. Chaining them runs one at a time so the queue stays available for other tasks.
maperu
force-pushed
the
maperu/chainSourceSyncs
branch
from
1e06f89 to
79fe283
Compare
nlopez
approved these changes
Apr 1, 2026
evan-datadog
approved these changes
Apr 1, 2026
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since dd.45 fixed COA source syncs, lemur now actually completes syncs instead of failing immediately. With 20+ COA sources fetching certs from vault the 2 celery workers get tied up during the bi-hourly sync_all_sources run. Lightweight minutely tasks like metrics reporting can't execute, get revoked by celery, and the revocation persists across pod restarts. This causes the task monitors to show "No Data" and declare incidents.
This chains them so they run one at a time, keeping the queue available for other tasks.
Companion PR for the worker concurrency bump: https://github.com/DataDog/k8s-resources/pull/145229