Skip to content

deps(library_config): bump to v18.1.0#51

Merged
dmehala merged 8 commits intomainfrom
dmehala/bump-dd-lib-config
Jun 2, 2025
Merged

deps(library_config): bump to v18.1.0#51
dmehala merged 8 commits intomainfrom
dmehala/bump-dd-lib-config

Conversation

@dmehala
Copy link
Copy Markdown
Contributor

@dmehala dmehala commented May 27, 2025

Preparatory changes to facilitate shared in-memory tracing configuration (memfd config) support.

Preparatory changes to facilitate memfd configuration support.
@dmehala dmehala requested review from BaptisteFoy and rochdev May 27, 2025 10:22
Copy link
Copy Markdown
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem like library_config tests are failing at the moment.

@szegedi
Copy link
Copy Markdown
Contributor

szegedi commented May 28, 2025

Also, shouldn't there be a bump of Rust in rust-toolchain.toml? Without it, I'm getting:

error: rustc 1.80.0 is not supported by the following package:
  backtrace@0.3.75 requires rustc 1.82.0

when trying to do cargo check (or deleting Cargo.lock.) Seeing how you made that to_str -> to_string change I'd think that you did actually update it.

szegedi
szegedi previously approved these changes May 28, 2025
Copy link
Copy Markdown
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As a minor suggestion, you can consider bumping wasm-bindgen to 0.2.100 and wasm-bindgen-test to 0.3.50, their latest versions.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 28, 2025

Overall package size

Self size: 30.6 MB
Deduped: 30.6 MB
No deduping: 30.6 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------|

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@dmehala
Copy link
Copy Markdown
Contributor Author

dmehala commented May 28, 2025

@szegedi bump wasm dependencies in 881ba23

@dmehala dmehala requested a review from szegedi May 28, 2025 14:33
.into_iter()
.map(|c| ConfigEntry {
name: c.name.to_str().into(),
name: c.name.to_string().into(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going back to Rustc 1.80 would this now remain to_str? Also, would you try to downgrade Rustc to 1.78, the same one libdatadog uses?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 71ae510.
However, I had to use to_string instead of to_str.

@dmehala dmehala requested a review from szegedi June 2, 2025 11:29
Copy link
Copy Markdown
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dmehala dmehala merged commit 83baa89 into main Jun 2, 2025
42 checks passed
@dmehala dmehala changed the title deps(library_config): bump to v18.0.0 deps(library_config): bump to v18.1.0 Jun 2, 2025
szegedi pushed a commit that referenced this pull request Jun 3, 2025
@szegedi szegedi mentioned this pull request Jun 3, 2025
szegedi pushed a commit that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants