Conversation
Preparatory changes to facilitate memfd configuration support.
szegedi
left a comment
There was a problem hiding this comment.
Seem like library_config tests are failing at the moment.
|
Also, shouldn't there be a bump of Rust in when trying to do |
szegedi
left a comment
There was a problem hiding this comment.
Looks good! As a minor suggestion, you can consider bumping wasm-bindgen to 0.2.100 and wasm-bindgen-test to 0.3.50, their latest versions.
Overall package sizeSelf size: 30.6 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
| .into_iter() | ||
| .map(|c| ConfigEntry { | ||
| name: c.name.to_str().into(), | ||
| name: c.name.to_string().into(), |
There was a problem hiding this comment.
Going back to Rustc 1.80 would this now remain to_str? Also, would you try to downgrade Rustc to 1.78, the same one libdatadog uses?
There was a problem hiding this comment.
addressed in 71ae510.
However, I had to use to_string instead of to_str.
Preparatory changes to facilitate shared in-memory tracing configuration (memfd config) support.