-
Notifications
You must be signed in to change notification settings - Fork 15
build: fix macOS cross-platform build to set target OS and Arch env vars #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksComparisonBenchmark execution time: 2025-09-03 14:45:25 Comparing candidate commit ca0feb4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
BaselineOmitted due to size. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
- Coverage 71.81% 71.78% -0.04%
==========================================
Files 349 349
Lines 55158 55158
==========================================
- Hits 39613 39593 -20
- Misses 15545 15565 +20
🚀 New features to boost your workflow:
|
0e6cf76 to
2dbd515
Compare
d5651a0 to
29ddad3
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status waiting |
What does this PR do?
This PR sets the
CARGO_CFG_TARGET_OSandCARGO_CFG_TARGET_ARCHenv variables for when we package ffi on macos x86 64.Motivation
libdatadogCI was broken after these changes.Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.
https://gitlab.ddbuild.io/DataDog/apm-reliability/libddprof-build/-/pipelines/75353209