-
Notifications
You must be signed in to change notification settings - Fork 15
Move cc_utils code to ddcommon #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksComparisonBenchmark execution time: 2025-10-24 12:44:26 Comparing candidate commit 89225f4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 71.80% 72.01% +0.20%
==========================================
Files 368 368
Lines 57967 57897 -70
==========================================
+ Hits 41626 41694 +68
+ Misses 16341 16203 -138
🚀 New features to boost your workflow:
|
|
Thanks for doing this! |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Move cc_utils code to ddcommon Remove cc_utils from license and Dockerfile Try with cc=1.0 in ddcommon Try with cc=1.0 in spawn_worker Co-authored-by: julio.gonzalez <julio.gonzalez@datadoghq.com>
What does this PR do?
Move
cc_utilscode toddcommoncrateMotivation
Reduce the number of crates that are published to crates.io.
As
datadog-crashtrackerdepends oncc_utils, when publishingdatadog-crashtracker, we would be obliged to publishcc_utilsas well.Additional Notes
I have considered to add a new feature for
cc_utils, do you think it makes sense?