Skip to content

Conversation

@dd-oleksii
Copy link
Member

What does this PR do?

Allow passing Number as expected flag type into eval.

Motivation

In some languages, there's less distinction between integer/float flags and the user may request "number" flag. In that case, we should match either integer or float.

This PR is going to be used for Python and Ruby bindings.

Copy link

@leoromanovsky leoromanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea moving the naming up to flag level

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-11-07 15:00:42

Comparing candidate commit 81b8c7c in PR branch oleksii/ffe-support-number-expected-type with baseline commit 8f6c103 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.389µs 538.024µs ± 1.907µs 537.801µs ± 1.375µs 539.066µs 541.841µs 542.692µs 543.397µs 1.04% 0.732 -0.279 0.35% 0.135µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1840275.955op/s 1858677.387op/s ± 6572.792op/s 1859424.759op/s ± 4752.585op/s 1864246.655op/s 1866586.519op/s 1867317.521op/s 1867799.564op/s 0.45% -0.719 -0.304 0.35% 464.767op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.518µs 381.187µs ± 0.340µs 381.164µs ± 0.224µs 381.404µs 381.784µs 381.932µs 382.451µs 0.34% 0.488 0.142 0.09% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2614710.772op/s 2623383.370op/s ± 2337.816op/s 2623542.323op/s ± 1544.498op/s 2625007.344op/s 2626799.451op/s 2627684.746op/s 2627999.876op/s 0.17% -0.482 0.132 0.09% 165.309op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.838µs 190.495µs ± 0.223µs 190.500µs ± 0.129µs 190.626µs 190.856µs 190.983µs 191.034µs 0.28% -0.302 0.383 0.12% 0.016µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5234677.294op/s 5249478.025op/s ± 6154.040op/s 5249357.257op/s ± 3551.590op/s 5252990.240op/s 5259991.004op/s 5266410.057op/s 5267649.259op/s 0.35% 0.310 0.392 0.12% 435.156op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.793µs 37.931µs ± 0.054µs 37.930µs ± 0.038µs 37.967µs 38.022µs 38.047µs 38.144µs 0.56% 0.348 0.335 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26216205.672op/s 26363766.151op/s ± 37810.346op/s 26364194.083op/s ± 26116.169op/s 26391881.166op/s 26418408.902op/s 26435791.306op/s 26460047.297op/s 0.36% -0.338 0.316 0.14% 2673.595op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.885µs 45.972µs ± 0.051µs 45.962µs ± 0.021µs 45.990µs 46.057µs 46.118µs 46.394µs 0.94% 3.328 21.843 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21554454.575op/s 21752208.031op/s ± 24237.319op/s 21757222.038op/s ± 9930.406op/s 21766038.305op/s 21777817.360op/s 21786515.316op/s 21793741.128op/s 0.17% -3.286 21.376 0.11% 1713.837op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [537.759µs; 538.288µs] or [-0.049%; +0.049%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1857766.462op/s; 1859588.313op/s] or [-0.049%; +0.049%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.140µs; 381.235µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2623059.371op/s; 2623707.369op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.464µs; 190.526µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5248625.134op/s; 5250330.915op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.923µs; 37.938µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26358526.001op/s; 26369006.302op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.965µs; 45.980µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21748848.971op/s; 21755567.090op/s] or [-0.015%; +0.015%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 2.111µs 3.916µs ± 1.750µs 3.692µs ± 0.023µs 3.713µs 4.413µs 15.649µs 19.918µs 439.49% 7.762 61.476 44.58% 0.124µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.674µs; 4.159µs] or [-6.194%; +6.194%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.588µs 35.075µs ± 0.809µs 34.692µs ± 0.065µs 34.861µs 36.735µs 36.787µs 38.715µs 11.59% 1.822 2.095 2.30% 0.057µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.963µs; 35.187µs] or [-0.320%; +0.320%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 8.070ms 8.418ms ± 0.089ms 8.435ms ± 0.021ms 8.455ms 8.495ms 8.579ms 8.741ms 3.62% -1.809 5.611 1.06% 0.006ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [8.406ms; 8.430ms] or [-0.147%; +0.147%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.903ms 13.965ms ± 0.038ms 13.962ms ± 0.020ms 13.982ms 14.026ms 14.100ms 14.180ms 1.56% 1.854 6.494 0.27% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [13.960ms; 13.970ms] or [-0.037%; +0.037%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 86.050µs 86.565µs ± 0.307µs 86.547µs ± 0.088µs 86.628µs 86.802µs 87.057µs 90.364µs 4.41% 9.510 115.132 0.35% 0.022µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.523µs; 86.608µs] or [-0.049%; +0.049%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.923µs 5.015µs ± 0.059µs 5.001µs ± 0.014µs 5.012µs 5.142µs 5.143µs 5.145µs 2.88% 0.989 -0.040 1.17% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.007µs; 5.023µs] or [-0.162%; +0.162%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.783ms 61.549ms ± 2.339ms 61.210ms ± 0.159ms 61.417ms 61.747ms 74.854ms 84.521ms 38.08% 8.106 67.974 3.79% 0.165ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.225ms; 61.873ms] or [-0.527%; +0.527%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 171.809ns 175.107ns ± 2.672ns 174.546ns ± 1.545ns 176.109ns 180.565ns 183.585ns 185.024ns 6.00% 1.186 1.316 1.52% 0.189ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [174.737ns; 175.478ns] or [-0.211%; +0.211%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.661ns 253.874ns ± 13.732ns 247.736ns ± 2.134ns 254.036ns 290.122ns 295.880ns 299.436ns 20.87% 1.844 2.176 5.40% 0.971ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.971ns; 255.777ns] or [-0.750%; +0.750%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.069µs 205.720µs ± 0.332µs 205.653µs ± 0.211µs 205.898µs 206.408µs 206.636µs 206.814µs 0.56% 0.788 0.373 0.16% 0.023µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4835260.076op/s 4860979.856op/s ± 7824.131op/s 4862569.335op/s ± 4993.459op/s 4866827.487op/s 4871195.808op/s 4873755.860op/s 4876402.954op/s 0.28% -0.780 0.353 0.16% 553.250op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.604µs 18.764µs ± 0.117µs 18.728µs ± 0.064µs 18.828µs 18.980µs 19.131µs 19.378µs 3.47% 1.437 3.201 0.62% 0.008µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 51605048.198op/s 53295590.722op/s ± 329501.247op/s 53396697.854op/s ± 183139.072op/s 53536287.281op/s 53647738.176op/s 53691219.940op/s 53752419.998op/s 0.67% -1.380 2.859 0.62% 23299.257op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.848µs 10.931µs ± 0.031µs 10.927µs ± 0.021µs 10.952µs 10.986µs 11.001µs 11.015µs 0.80% 0.122 0.050 0.28% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 90784726.544op/s 91481292.910op/s ± 256472.851op/s 91513518.381op/s ± 173079.938op/s 91652663.692op/s 91911792.121op/s 92067832.095op/s 92182307.049op/s 0.73% -0.105 0.050 0.28% 18135.369op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.674µs; 205.766µs] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4859895.506op/s; 4862064.205op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.748µs; 18.780µs] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53249925.018op/s; 53341256.426op/s] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.927µs; 10.936µs] or [-0.039%; +0.039%] None None None
normalization/normalize_name/normalize_name/good throughput [91445748.240op/s; 91516837.581op/s] or [-0.039%; +0.039%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 121.834µs 123.536µs ± 2.513µs 123.185µs ± 0.479µs 123.633µs 124.721µs 130.769µs 152.705µs 23.96% 8.731 92.216 2.03% 0.178µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [123.188µs; 123.884µs] or [-0.282%; +0.282%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.657ms 10.685ms ± 0.015ms 10.683ms ± 0.008ms 10.692ms 10.710ms 10.720ms 10.781ms 0.92% 2.050 9.714 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.683ms; 10.687ms] or [-0.019%; +0.019%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.404µs 2.423µs ± 0.012µs 2.422µs ± 0.008µs 2.430µs 2.448µs 2.462µs 2.474µs 2.12% 1.006 1.525 0.51% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.422µs; 2.425µs] or [-0.071%; +0.071%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.891µs 3.917µs ± 0.003µs 3.918µs ± 0.002µs 3.919µs 3.921µs 3.923µs 3.924µs 0.15% -2.921 22.411 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 254856925.378op/s 255274381.378op/s ± 208253.644op/s 255240219.642op/s ± 114288.938op/s 255415848.561op/s 255548558.058op/s 255607582.925op/s 257018264.096op/s 0.70% 2.960 22.826 0.08% 14725.756op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.107µs 77.529µs ± 0.532µs 77.258µs ± 0.115µs 77.724µs 78.671µs 79.908µs 80.019µs 3.57% 2.355 6.619 0.68% 0.038µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12497046.483op/s 12899000.883op/s ± 87121.585op/s 12943567.403op/s ± 19225.663op/s 12954359.082op/s 12963948.827op/s 12965225.606op/s 12968952.027op/s 0.20% -2.293 6.236 0.67% 6160.426op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.711µs 71.261µs ± 0.690µs 70.962µs ± 0.214µs 71.443µs 72.873µs 73.358µs 73.381µs 3.41% 1.657 1.888 0.97% 0.049µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13627559.758op/s 14034229.500op/s ± 133829.501op/s 14092074.112op/s ± 42528.104op/s 14126427.015op/s 14138572.926op/s 14141281.555op/s 14141997.490op/s 0.35% -1.624 1.768 0.95% 9463.175op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.892µs 3.915µs ± 0.003µs 3.915µs ± 0.001µs 3.916µs 3.920µs 3.922µs 3.924µs 0.24% -2.274 22.956 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254816571.977op/s 255424575.158op/s ± 185252.874op/s 255433857.758op/s ± 85476.433op/s 255518867.384op/s 255622749.690op/s 255678765.627op/s 256967708.597op/s 0.60% 2.317 23.344 0.07% 13099.356op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.487µs 68.046µs ± 0.414µs 68.030µs ± 0.271µs 68.293µs 68.699µs 69.366µs 70.136µs 3.10% 1.343 3.911 0.61% 0.029µs 1 200
credit_card/is_card_number/378282246310005 throughput 14258035.130op/s 14696522.928op/s ± 88703.631op/s 14699467.144op/s ± 58573.363op/s 14760377.037op/s 14810484.363op/s 14815753.870op/s 14817747.751op/s 0.80% -1.270 3.519 0.60% 6272.294op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.653µs 44.855µs ± 0.113µs 44.858µs ± 0.087µs 44.924µs 45.033µs 45.110µs 45.279µs 0.94% 0.522 0.425 0.25% 0.008µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 22085500.268op/s 22294291.733op/s ± 55931.321op/s 22292635.326op/s ± 43144.867op/s 22338558.912op/s 22371714.996op/s 22392514.765op/s 22394786.494op/s 0.46% -0.506 0.379 0.25% 3954.942op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.036µs 6.043µs ± 0.004µs 6.042µs ± 0.003µs 6.045µs 6.050µs 6.055µs 6.058µs 0.25% 0.908 1.001 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165083750.097op/s 165481485.359op/s ± 110510.788op/s 165497457.797op/s ± 73525.728op/s 165565831.352op/s 165623953.368op/s 165661125.321op/s 165679028.897op/s 0.11% -0.904 0.989 0.07% 7814.293op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.916µs ± 0.003µs 3.916µs ± 0.002µs 3.918µs 3.922µs 3.923µs 3.927µs 0.27% -1.281 13.169 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254677087.395op/s 255350179.000op/s ± 200696.792op/s 255373475.215op/s ± 98627.232op/s 255464273.322op/s 255576487.654op/s 255622029.612op/s 256814608.298op/s 0.56% 1.313 13.411 0.08% 14191.406op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.370µs 65.581µs ± 0.098µs 65.576µs ± 0.069µs 65.638µs 65.739µs 65.859µs 65.904µs 0.50% 0.556 0.371 0.15% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15173525.629op/s 15248326.391op/s ± 22844.499op/s 15249392.607op/s ± 15946.011op/s 15265763.092op/s 15280346.123op/s 15292899.156op/s 15297462.151op/s 0.32% -0.547 0.353 0.15% 1615.350op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.038µs 53.083µs ± 0.030µs 53.081µs ± 0.022µs 53.101µs 53.138µs 53.170µs 53.198µs 0.22% 0.891 0.750 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18797874.905op/s 18838285.103op/s ± 10765.791op/s 18839261.280op/s ± 7774.935op/s 18847220.715op/s 18852415.372op/s 18853561.472op/s 18854255.805op/s 0.08% -0.888 0.739 0.06% 761.256op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.888µs 3.915µs ± 0.003µs 3.915µs ± 0.001µs 3.917µs 3.919µs 3.921µs 3.923µs 0.21% -4.098 40.464 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254880578.868op/s 255401404.222op/s ± 187052.511op/s 255405452.908op/s ± 87853.249op/s 255491133.688op/s 255593055.838op/s 255657738.820op/s 257199030.056op/s 0.70% 4.155 41.120 0.07% 13226.610op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.793µs 49.850µs ± 0.028µs 49.846µs ± 0.019µs 49.868µs 49.897µs 49.926µs 49.942µs 0.19% 0.640 0.370 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 20023081.333op/s 20060231.744op/s ± 11282.580op/s 20061622.117op/s ± 7560.650op/s 20068798.537op/s 20077036.187op/s 20080390.194op/s 20083150.237op/s 0.11% -0.636 0.363 0.06% 797.799op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.588µs 44.755µs ± 0.098µs 44.738µs ± 0.061µs 44.806µs 44.955µs 45.030µs 45.119µs 0.85% 0.902 0.848 0.22% 0.007µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 22163451.696op/s 22344160.392op/s ± 48783.844op/s 22352325.842op/s ± 30494.307op/s 22378421.048op/s 22413898.971op/s 22421850.431op/s 22427370.363op/s 0.34% -0.889 0.812 0.22% 3449.539op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.035µs 6.042µs ± 0.004µs 6.042µs ± 0.003µs 6.045µs 6.049µs 6.051µs 6.052µs 0.16% 0.402 -0.278 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165236530.352op/s 165495630.948op/s ± 98098.510op/s 165502763.896op/s ± 71285.614op/s 165575237.388op/s 165640694.378op/s 165666203.480op/s 165689515.668op/s 0.11% -0.399 -0.282 0.06% 6936.612op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.917µs; 3.918µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255245519.426op/s; 255303243.331op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.455µs; 77.603µs] or [-0.095%; +0.095%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12886926.669op/s; 12911075.097op/s] or [-0.094%; +0.094%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.165µs; 71.357µs] or [-0.134%; +0.134%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14015682.018op/s; 14052776.981op/s] or [-0.132%; +0.132%] None None None
credit_card/is_card_number/37828224631 execution_time [3.915µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255398900.891op/s; 255450249.424op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.988µs; 68.103µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/378282246310005 throughput [14684229.458op/s; 14708816.398op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [44.839µs; 44.870µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22286540.190op/s; 22302043.276op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.042µs; 6.044µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [165466169.627op/s; 165496801.092op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.916µs; 3.917µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255322364.354op/s; 255377993.645op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.567µs; 65.595µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15245160.363op/s; 15251492.418op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.079µs; 53.088µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18836793.068op/s; 18839777.139op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.915µs; 3.916µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255375480.543op/s; 255427327.901op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [49.846µs; 49.854µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [20058668.087op/s; 20061795.401op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [44.741µs; 44.768µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22337399.420op/s; 22350921.364op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.042µs; 6.043µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165482035.438op/s; 165509226.458op/s] or [-0.008%; +0.008%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 24.884µs 30.058µs ± 10.104µs 25.601µs ± 0.081µs 25.689µs 55.020µs 56.262µs 88.318µs 244.98% 2.503 6.822 33.53% 0.714µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [28.658µs; 31.459µs] or [-4.659%; +4.659%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz 81b8c7c 1762526548 oleksii/ffe-support-number-expected-type
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 171.431µs 172.027µs ± 0.337µs 171.971µs ± 0.151µs 172.142µs 172.451µs 172.809µs 175.222µs 1.89% 4.825 40.688 0.20% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [171.980µs; 172.073µs] or [-0.027%; +0.027%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 85.96491% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.86%. Comparing base (70b601d) to head (81b8c7c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
- Coverage   71.86%   71.86%   -0.01%     
==========================================
  Files         369      370       +1     
  Lines       58473    58499      +26     
==========================================
+ Hits        42023    42040      +17     
- Misses      16450    16459       +9     
Components Coverage Δ
datadog-crashtracker 50.65% <ø> (-0.03%) ⬇️
datadog-crashtracker-ffi 5.86% <ø> (ø)
datadog-alloc ∅ <ø> (∅)
data-pipeline 87.89% <ø> (ø)
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 80.95% <ø> (ø)
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry ∅ <ø> (∅)
ddtelemetry-ffi ∅ <ø> (∅)
dogstatsd-client ∅ <ø> (∅)
datadog-ipc 82.59% <ø> (ø)
datadog-profiling 75.92% <ø> (ø)
datadog-profiling-ffi 62.11% <ø> (ø)
datadog-sidecar 38.28% <ø> (ø)
datdog-sidecar-ffi 19.14% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
tinybytes ∅ <ø> (∅)
datadog-trace-normalization ∅ <ø> (∅)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf ∅ <ø> (∅)
datadog-trace-utils 90.28% <ø> (ø)
datadog-tracer-flare 64.98% <ø> (ø)
datadog-log ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dd-oleksii
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 7, 2025

View all feedbacks in Devflow UI.

2025-11-07 15:06:20 UTC ℹ️ Start processing command /merge


2025-11-07 15:06:27 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-11-07 15:07:28 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 35m (p90).


2025-11-07 15:24:56 UTC ℹ️ MergeQueue: This merge request was merged

@dd-octo-sts
Copy link

dd-octo-sts bot commented Nov 7, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 82.75 MB 82.75 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.50 MB 7.50 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.91 MB 95.91 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.54 MB 9.54 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.86 MB 18.86 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 52.66 KB 52.66 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 131.01 MB 131.03 MB +.01% (+16.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 689.36 MB 689.36 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.24 MB 6.24 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 52.66 KB 52.66 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 18.86 MB 18.86 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 36.45 MB 36.45 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.96 MB 15.96 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 53.48 KB 53.48 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 133.21 MB 133.22 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 678.58 MB 678.58 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.79 MB 4.79 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 53.48 KB 53.48 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 20.01 MB 20.01 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 34.22 MB 34.22 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 71.73 MB 71.73 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.91 MB 8.91 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 90.70 MB 90.70 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.25 MB 10.25 MB 0% (0 B) 👌

@dd-mergequeue dd-mergequeue bot merged commit a5f205d into main Nov 7, 2025
37 checks passed
@dd-mergequeue dd-mergequeue bot deleted the oleksii/ffe-support-number-expected-type branch November 7, 2025 15:24
anais-raison pushed a commit that referenced this pull request Nov 10, 2025
feat(ffe): support multiple/number expected flag type

Co-authored-by: oleksii.shmalko <oleksii.shmalko@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants