-
Notifications
You must be signed in to change notification settings - Fork 15
feat(ffe): support number expected flag type
#1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
leoromanovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea moving the naming up to flag level
BenchmarksComparisonBenchmark execution time: 2025-11-07 15:00:42 Comparing candidate commit 81b8c7c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
- Coverage 71.86% 71.86% -0.01%
==========================================
Files 369 370 +1
Lines 58473 58499 +26
==========================================
+ Hits 42023 42040 +17
- Misses 16450 16459 +9
🚀 New features to boost your workflow:
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
feat(ffe): support multiple/number expected flag type Co-authored-by: oleksii.shmalko <oleksii.shmalko@datadoghq.com>
What does this PR do?
Allow passing
Numberas expected flag type into eval.Motivation
In some languages, there's less distinction between integer/float flags and the user may request "number" flag. In that case, we should match either integer or float.
This PR is going to be used for Python and Ruby bindings.