Skip to content

feat(ffe): remove unstable flag metadata keys #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 1 commit into from
Nov 25, 2025
Merged

feat(ffe): remove unstable flag metadata keys #1369

dd-mergequeue merged 1 commit into from
Nov 25, 2025

Conversation

@dd-oleksii
Copy link
Member

@dd-oleksii dd-oleksii commented Nov 24, 2025

What does this PR do?

Remove flag metadata keys that we didn't intend to make public.

Motivation

We have decided to not expose any flag metadata keys until we standardize what metadata we actually want to expose and commit to.

Additional Notes

Stacked on top #1368 to avoid conflicts.

@dd-oleksii dd-oleksii requested a review from a team as a code owner November 24, 2025 20:58
@pr-commenter
Copy link

pr-commenter bot commented Nov 24, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-11-25 14:57:43

Comparing candidate commit a9e9724 in PR branch oleksii/ffe-remove-unstable-flag-metadata-keys with baseline commit 6a912a8 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics.

scenario:tags/replace_trace_tags

  • 🟥 execution_time [+102.358ns; +112.274ns] or [+4.308%; +4.726%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.412µs 2.483µs ± 0.033µs 2.485µs ± 0.017µs 2.499µs 2.524µs 2.535µs 2.700µs 8.63% 2.235 14.034 1.34% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.478µs; 2.488µs] or [-0.187%; +0.187%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.020µs 205.544µs ± 0.398µs 205.452µs ± 0.194µs 205.686µs 206.106µs 206.709µs 209.019µs 1.74% 3.875 28.208 0.19% 0.028µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4784259.012op/s 4865163.504op/s ± 9352.163op/s 4867316.300op/s ± 4611.899op/s 4870792.360op/s 4874288.702op/s 4875803.790op/s 4877564.561op/s 0.21% -3.788 27.177 0.19% 661.298op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.224µs 18.343µs ± 0.071µs 18.319µs ± 0.031µs 18.369µs 18.490µs 18.584µs 18.603µs 1.55% 1.342 1.526 0.39% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53756166.584op/s 54516932.488op/s ± 210107.978op/s 54586857.289op/s ± 93566.911op/s 54650408.174op/s 54757114.840op/s 54784992.775op/s 54871291.945op/s 0.52% -1.322 1.458 0.38% 14856.878op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.587µs 10.839µs ± 0.111µs 10.860µs ± 0.087µs 10.926µs 10.982µs 11.004µs 11.148µs 2.65% -0.303 -0.850 1.02% 0.008µs 1 200
normalization/normalize_name/normalize_name/good throughput 89699547.599op/s 92266867.506op/s ± 948090.264op/s 92080486.869op/s ± 737155.985op/s 93068724.504op/s 93861958.187op/s 94178337.192op/s 94459823.209op/s 2.58% 0.335 -0.853 1.02% 67040.105op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.489µs; 205.599µs] or [-0.027%; +0.027%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4863867.384op/s; 4866459.624op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.333µs; 18.353µs] or [-0.054%; +0.054%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54487813.543op/s; 54546051.433op/s] or [-0.053%; +0.053%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.824µs; 10.855µs] or [-0.142%; +0.142%] None None None
normalization/normalize_name/normalize_name/good throughput [92135471.314op/s; 92398263.698op/s] or [-0.142%; +0.142%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.154µs 3.260µs ± 1.458µs 3.021µs ± 0.044µs 3.059µs 3.692µs 14.056µs 15.037µs 397.78% 7.229 53.979 44.60% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.058µs; 3.462µs] or [-6.196%; +6.196%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 242.650ns 254.346ns ± 14.019ns 247.645ns ± 3.312ns 261.706ns 286.318ns 291.189ns 292.093ns 17.95% 1.413 0.610 5.50% 0.991ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.403ns; 256.289ns] or [-0.764%; +0.764%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.293µs 146.674µs ± 1.733µs 146.347µs ± 0.520µs 147.010µs 148.604µs 153.291µs 162.678µs 11.16% 5.193 39.423 1.18% 0.123µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.434µs; 146.914µs] or [-0.164%; +0.164%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.780µs 25.828µs ± 9.402µs 18.209µs ± 0.285µs 33.284µs 42.541µs 43.524µs 69.090µs 279.42% 0.953 0.807 36.31% 0.665µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.525µs; 27.130µs] or [-5.045%; +5.045%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.595ms 10.627ms ± 0.015ms 10.626ms ± 0.010ms 10.637ms 10.651ms 10.668ms 10.707ms 0.76% 1.025 3.458 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.625ms; 10.629ms] or [-0.020%; +0.020%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 86.707µs 86.993µs ± 0.165µs 86.975µs ± 0.059µs 87.032µs 87.166µs 87.315µs 88.685µs 1.97% 6.179 57.172 0.19% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.970µs; 87.016µs] or [-0.026%; +0.026%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.920ms 61.460ms ± 2.057ms 61.176ms ± 0.102ms 61.309ms 61.560ms 72.729ms 80.811ms 32.10% 8.331 70.016 3.34% 0.145ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.175ms; 61.745ms] or [-0.464%; +0.464%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.822ms 14.888ms ± 0.029ms 14.885ms ± 0.013ms 14.898ms 14.925ms 14.997ms 15.047ms 1.09% 2.031 7.581 0.20% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.884ms; 14.893ms] or [-0.027%; +0.027%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.325ms 6.407ms ± 0.029ms 6.403ms ± 0.012ms 6.416ms 6.454ms 6.492ms 6.554ms 2.35% 1.582 6.238 0.45% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.403ms; 6.410ms] or [-0.062%; +0.062%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 158.748µs 159.720µs ± 0.343µs 159.679µs ± 0.208µs 159.923µs 160.380µs 160.871µs 161.011µs 0.83% 0.743 1.840 0.21% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [159.673µs; 159.768µs] or [-0.030%; +0.030%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.896µs 3.916µs ± 0.003µs 3.916µs ± 0.001µs 3.917µs 3.919µs 3.921µs 3.922µs 0.15% -2.139 14.155 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254969764.020op/s 255376430.648op/s ± 175994.753op/s 255352070.416op/s ± 91029.553op/s 255461725.940op/s 255640573.166op/s 255761588.574op/s 256691595.099op/s 0.52% 2.163 14.369 0.07% 12444.708op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.883µs 79.333µs ± 0.633µs 79.292µs ± 0.426µs 79.762µs 80.461µs 80.722µs 80.759µs 1.85% 0.201 -0.435 0.80% 0.045µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12382581.678op/s 12605879.180op/s ± 100500.588op/s 12611600.882op/s ± 67783.798op/s 12676796.033op/s 12760493.079op/s 12824218.491op/s 12839815.657op/s 1.81% -0.164 -0.437 0.80% 7106.465op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 71.427µs 71.710µs ± 0.475µs 71.536µs ± 0.044µs 71.611µs 72.835µs 73.827µs 74.041µs 3.50% 2.976 8.737 0.66% 0.034µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13506077.349op/s 13945592.195op/s ± 90680.515op/s 13978897.456op/s ± 8614.053op/s 13986057.651op/s 13994449.871op/s 13997246.408op/s 14000222.604op/s 0.15% -2.939 8.475 0.65% 6412.081op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.896µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.919µs 3.921µs 3.925µs 0.29% -0.834 8.253 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254745304.567op/s 255463410.446op/s ± 187638.562op/s 255472183.720op/s ± 93175.873op/s 255560728.531op/s 255736604.355op/s 255819994.781op/s 256670441.685op/s 0.47% 0.855 8.369 0.07% 13268.050op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 68.224µs 68.588µs ± 0.587µs 68.325µs ± 0.044µs 68.575µs 69.798µs 70.865µs 71.655µs 4.87% 2.551 6.898 0.85% 0.041µs 1 200
credit_card/is_card_number/378282246310005 throughput 13955850.952op/s 14580944.638op/s ± 122080.123op/s 14635968.625op/s ± 9473.987op/s 14643556.160op/s 14648969.160op/s 14653900.858op/s 14657561.711op/s 0.15% -2.492 6.467 0.84% 8632.368op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 45.428µs 45.705µs ± 0.123µs 45.706µs ± 0.080µs 45.782µs 45.864µs 45.933µs 46.424µs 1.57% 1.083 5.656 0.27% 0.009µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21540787.974op/s 21879709.397op/s ± 58572.120op/s 21878781.957op/s ± 38309.258op/s 21921881.966op/s 21975308.879op/s 21998248.980op/s 22012979.416op/s 0.61% -1.032 5.359 0.27% 4141.674op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.568µs 6.618µs ± 0.018µs 6.620µs ± 0.014µs 6.635µs 6.641µs 6.643µs 6.646µs 0.39% -0.657 -0.418 0.28% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 150456914.679op/s 151103798.258op/s ± 423015.574op/s 151046295.091op/s ± 326115.620op/s 151384609.808op/s 151962294.254op/s 152153939.587op/s 152245980.399op/s 0.79% 0.666 -0.399 0.28% 29911.718op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.896µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.919µs 3.920µs 3.921µs 0.17% -1.461 12.102 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255041640.990op/s 255469104.124op/s ± 164878.501op/s 255477575.768op/s ± 92960.048op/s 255561892.076op/s 255689829.540op/s 255723785.695op/s 256655481.619op/s 0.46% 1.484 12.284 0.06% 11658.671op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.567µs 65.712µs ± 0.055µs 65.711µs ± 0.037µs 65.749µs 65.809µs 65.831µs 65.849µs 0.21% 0.058 -0.236 0.08% 0.004µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15186348.406op/s 15217851.156op/s ± 12806.814op/s 15218108.316op/s ± 8633.546op/s 15226506.980op/s 15238984.099op/s 15247176.006op/s 15251550.400op/s 0.22% -0.054 -0.236 0.08% 905.578op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.356µs 53.448µs ± 0.048µs 53.441µs ± 0.036µs 53.489µs 53.533µs 53.556µs 53.558µs 0.22% 0.282 -0.740 0.09% 0.003µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18671426.689op/s 18709630.175op/s ± 16848.377op/s 18712070.111op/s ± 12730.524op/s 18721987.817op/s 18734683.587op/s 18740231.536op/s 18742098.162op/s 0.16% -0.279 -0.742 0.09% 1191.360op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.915µs ± 0.003µs 3.915µs ± 0.002µs 3.916µs 3.920µs 3.921µs 3.924µs 0.24% -1.162 10.088 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254843294.315op/s 255441709.116op/s ± 205910.710op/s 255451272.684op/s ± 116514.565op/s 255568319.805op/s 255682819.614op/s 255756743.225op/s 256862217.398op/s 0.55% 1.188 10.277 0.08% 14560.086op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 50.151µs 50.232µs ± 0.038µs 50.228µs ± 0.026µs 50.259µs 50.302µs 50.314µs 50.335µs 0.21% 0.366 -0.419 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 19867008.260op/s 19907489.191op/s ± 15037.052op/s 19909147.593op/s ± 10233.691op/s 19918702.810op/s 19930270.860op/s 19937390.493op/s 19939839.510op/s 0.15% -0.363 -0.421 0.08% 1063.280op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 45.456µs 45.750µs ± 0.100µs 45.764µs ± 0.068µs 45.826µs 45.892µs 45.943µs 45.990µs 0.49% -0.352 -0.195 0.22% 0.007µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 21743691.128op/s 21857875.008op/s ± 47972.520op/s 21851153.940op/s ± 32436.161op/s 21890192.105op/s 21943427.250op/s 21971250.863op/s 21999225.306op/s 0.68% 0.363 -0.184 0.22% 3392.169op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.524µs 6.617µs ± 0.019µs 6.618µs ± 0.013µs 6.632µs 6.639µs 6.642µs 6.643µs 0.38% -1.186 2.443 0.28% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 150523329.723op/s 151133181.656op/s ± 430301.434op/s 151095167.854op/s ± 304666.330op/s 151350725.806op/s 151915851.703op/s 152166552.474op/s 153279606.113op/s 1.45% 1.212 2.579 0.28% 30426.906op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.915µs; 3.916µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255352039.467op/s; 255400821.828op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.245µs; 79.421µs] or [-0.111%; +0.111%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12591950.765op/s; 12619807.595op/s] or [-0.110%; +0.110%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.644µs; 71.776µs] or [-0.092%; +0.092%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13933024.748op/s; 13958159.643op/s] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255437405.546op/s; 255489415.346op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.506µs; 68.669µs] or [-0.119%; +0.119%] None None None
credit_card/is_card_number/378282246310005 throughput [14564025.507op/s; 14597863.769op/s] or [-0.116%; +0.116%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.688µs; 45.722µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [21871591.865op/s; 21887826.930op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.615µs; 6.621µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/x371413321323331 throughput [151045172.368op/s; 151162424.149op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.915µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255446253.549op/s; 255491954.698op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.705µs; 65.720µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15216076.255op/s; 15219626.057op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.442µs; 53.455µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18707295.152op/s; 18711965.198op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.915µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255413171.872op/s; 255470246.360op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [50.227µs; 50.238µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [19905405.200op/s; 19909573.182op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.736µs; 45.764µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [21851226.478op/s; 21864523.537op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.614µs; 6.619µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [151073546.016op/s; 151192817.297op/s] or [-0.039%; +0.039%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.342µs 33.910µs ± 0.837µs 33.534µs ± 0.092µs 33.688µs 35.664µs 35.719µs 37.118µs 10.69% 1.735 1.374 2.46% 0.059µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.794µs; 34.026µs] or [-0.342%; +0.342%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.024µs 5.084µs ± 0.038µs 5.092µs ± 0.038µs 5.119µs 5.132µs 5.137µs 5.150µs 1.13% -0.097 -1.596 0.75% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.079µs; 5.089µs] or [-0.104%; +0.104%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 192.745ns 194.541ns ± 1.911ns 193.631ns ± 0.617ns 195.223ns 197.802ns 199.478ns 209.039ns 7.96% 3.234 17.820 0.98% 0.135ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [194.276ns; 194.806ns] or [-0.136%; +0.136%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9e9724 1764081780 oleksii/ffe-remove-unstable-flag-metadata-keys
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.878µs 534.766µs ± 0.850µs 534.695µs ± 0.302µs 535.043µs 535.332µs 535.622µs 545.436µs 2.01% 9.922 122.288 0.16% 0.060µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1833397.251op/s 1869980.545op/s ± 2927.593op/s 1870224.670op/s ± 1055.576op/s 1871212.944op/s 1872380.412op/s 1872847.123op/s 1873086.697op/s 0.15% -9.799 120.252 0.16% 207.012op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.129µs 380.919µs ± 0.317µs 380.921µs ± 0.192µs 381.114µs 381.426µs 381.684µs 381.956µs 0.27% 0.150 0.356 0.08% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2618105.589op/s 2625229.775op/s ± 2183.261op/s 2625213.106op/s ± 1321.870op/s 2626506.169op/s 2628989.739op/s 2630407.841op/s 2630688.005op/s 0.21% -0.144 0.352 0.08% 154.380op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.513µs 194.945µs ± 0.174µs 194.945µs ± 0.122µs 195.065µs 195.218µs 195.352µs 195.536µs 0.30% 0.174 -0.058 0.09% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5114142.272op/s 5129667.597op/s ± 4578.255op/s 5129649.530op/s ± 3198.187op/s 5132930.056op/s 5137342.248op/s 5138267.833op/s 5141032.038op/s 0.22% -0.169 -0.064 0.09% 323.732op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.820µs 37.080µs ± 0.089µs 37.074µs ± 0.052µs 37.131µs 37.237µs 37.285µs 37.337µs 0.71% 0.004 0.372 0.24% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26782841.915op/s 26969127.098op/s ± 64923.362op/s 26973218.340op/s ± 37971.769op/s 27004506.652op/s 27071290.546op/s 27137221.502op/s 27159066.865op/s 0.69% 0.013 0.377 0.24% 4590.775op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.904µs 45.081µs ± 0.143µs 45.073µs ± 0.092µs 45.158µs 45.280µs 45.314µs 46.271µs 2.66% 2.962 22.419 0.32% 0.010µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21611777.554op/s 22182625.266op/s ± 69510.285op/s 22186209.350op/s ± 45285.318op/s 22234070.788op/s 22267726.734op/s 22268798.652op/s 22269764.044op/s 0.38% -2.818 20.870 0.31% 4915.119op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.648µs; 534.884µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1869574.808op/s; 1870386.281op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.875µs; 380.963µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2624927.196op/s; 2625532.354op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.920µs; 194.969µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5129033.095op/s; 5130302.099op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.067µs; 37.092µs] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26960129.344op/s; 26978124.851op/s] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.061µs; 45.101µs] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22172991.809op/s; 22192258.723op/s] or [-0.043%; +0.043%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.17%. Comparing base (6a912a8) to head (a9e9724).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1369      +/-   ##
==========================================
+ Coverage   71.15%   71.17%   +0.01%     
==========================================
  Files         392      392              
  Lines       62765    62755      -10     
==========================================
+ Hits        44662    44664       +2     
+ Misses      18103    18091      -12
Components Coverage Δ
libdd-crashtracker 59.88% <ø> (-0.04%) ⬇️
libdd-crashtracker-ffi 15.31% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 86.00% <ø> (ø)
libdd-data-pipeline-ffi 77.63% <ø> (ø)
libdd-common 80.93% <ø> (ø)
libdd-common-ffi 73.90% <ø> (ø)
libdd-telemetry 60.02% <ø> (ø)
libdd-telemetry-ffi 21.24% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.61% <ø> (-0.11%) ⬇️
libdd-profiling 79.75% <ø> (+0.02%) ⬆️
libdd-profiling-ffi 62.13% <ø> (ø)
datadog-sidecar 36.98% <ø> (ø)
datdog-sidecar-ffi 16.40% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 59.65% <ø> (ø)
libdd-trace-utils 90.06% <ø> (ø)
datadog-tracer-flare 62.06% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dd-octo-sts
Copy link

dd-octo-sts bot commented Nov 25, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 85.96 MB 85.96 MB +0% (+2.80 KB) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.38 MB 7.38 MB 0% (0 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 57.99 MB 58.00 MB +0% (+2.91 KB) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.43 MB 8.43 MB +0% (+288 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.70 MB 99.70 MB +0% (+4.63 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.53 MB 9.53 MB +0% (+320 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 19.57 MB 19.57 MB -0% (-512 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 69.82 KB 69.82 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 138.53 MB 138.54 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 735.58 MB 735.64 MB +0% (+68.53 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.34 MB 6.34 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 69.82 KB 69.82 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 19.67 MB 19.68 MB +.03% (+8.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 38.64 MB 38.64 MB +0% (+2.19 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 16.70 MB 16.70 MB -0% (-512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 70.90 KB 70.90 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 141.11 MB 141.08 MB --.01% (-24.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 724.31 MB 724.38 MB +0% (+68.71 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.87 MB 4.87 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 70.90 KB 70.90 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 20.90 MB 20.90 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 36.39 MB 36.39 MB +0% (+2.33 KB) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.32 MB 74.32 MB +0% (+2.72 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.85 MB 8.85 MB 0% (0 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 59.35 MB 59.36 MB +0% (+2.79 KB) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 9.47 MB 9.47 MB +0% (+296 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 93.93 MB 93.93 MB +0% (+3.58 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.28 MB 10.28 MB +0% (+304 B) 👌

@sameerank sameerank mentioned this pull request Nov 25, 2025
Merged
Base automatically changed from oleksii/FFL-1450-fix-memory-corruption to main November 25, 2025 13:37
@dd-mergequeue dd-mergequeue bot requested review from a team as code owners November 25, 2025 13:37
@dd-oleksii
feat(ffe): remove unstable flag metadata keys
a9e9724 
We have decided to not expose any flag metadata keys until we
standardize what metadata we actually want to expose and commit to.
@dd-oleksii dd-oleksii force-pushed the oleksii/ffe-remove-unstable-flag-metadata-keys branch from 072d911 to a9e9724 Compare November 25, 2025 14:43
@dd-oleksii
Copy link
Member Author

dd-oleksii commented Nov 25, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 25, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-11-25 14:43:20 UTC ℹ️ Start processing command /merge

2025-11-25 14:43:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-25 15:03:13 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 34m (p90).

2025-11-25 15:20:41 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 0808f16 into main Nov 25, 2025
37 checks passed
@dd-mergequeue dd-mergequeue bot deleted the oleksii/ffe-remove-unstable-flag-metadata-keys branch November 25, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leoromanovsky leoromanovsky leoromanovsky approved these changes

@sameerank sameerank sameerank approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dd-oleksii @codecov-commenter @leoromanovsky @sameerank