-
Notifications
You must be signed in to change notification settings - Fork 15
Fix CI #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #1389
Conversation
a440089 to
637a2ce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
- Coverage 71.15% 71.11% -0.04%
==========================================
Files 403 403
Lines 64084 64084
==========================================
- Hits 45597 45576 -21
- Misses 18487 18508 +21
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-12-08 09:57:23 Comparing candidate commit 759ec51 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
637a2ce to
d33f265
Compare
d33f265 to
759ec51
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
This PR fixes the windows job while running the
crashinfo.cpp(C++ crashtracker API).Motivation
Since the PR introducing the new C++ API for crashtracking, windows job failed to pass (test workflow was not running at all).
The failure appears due to a runtime library mismatch between the Rust library and the C++ example.
libdd-crashtracker, on windows, is compile with the dynamic runtime CRT flag. Butcrashinfo.cppis compiled using the static runtime.There also missing dependencies.