-
Notifications
You must be signed in to change notification settings - Fork 15
[crashtracker] Log errors in crashtracker receiver #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
+ Coverage 71.13% 71.14% +0.01%
==========================================
Files 403 403
Lines 64140 64275 +135
==========================================
+ Hits 45626 45731 +105
- Misses 18514 18544 +30
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-12-11 20:40:22 Comparing candidate commit 5f39eb6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b0b625f to
8eb3754
Compare
8eb3754 to
54fe369
Compare
54fe369 to
5f39eb6
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
gleocadie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|

What does this PR do?
We should emit Datadog logs to org2 when we encounter issues with crash report collection.
These logs go the same place that Telemetry crash uploads go to; lets reuse the uploader.
I also renamed and repositioned some of the methods in ErrorsIntakeUploader and TelemetryCrashUploader for clarity
Motivation
We currently have no telemetry into what issues we are running into with the crashtracker. Issues are only surfaced when we manually look through crash reports and notice missing/incomplete stacktraces, timeouts, etc. We should emit formal telemetry so that we can have sound metrics into our performance.
Additional Notes
AI usage:
Cursor did the first pass for commit has
e34bb30db9eb50e72a49932a772aaf31f069964b:First pass logger componentbut I did not like the design at all so I rewrote in the commit afterwardsHow to test the change?