feat(profiling-ffi): Profile_add2 & Profile_with_dictionary #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2025-12-17 19:56:15 Comparing candidate commit 0618837 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## levi/profiles-dictionary-ffi #1406 +/- ##
================================================================
- Coverage 71.73% 71.67% -0.07%
================================================================
Files 411 411
Lines 66018 66069 +51
================================================================
- Hits 47360 47354 -6
- Misses 18658 18715 +57
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
gyuheon0h
reviewed
Dec 16, 2025
gyuheon0h
approved these changes
Dec 16, 2025
- ArcHandle<ProfilesDictionary> -> ddog_prof_ProfilesDictionaryHandle - ProfileStatus -> ddog_prof_Status
morrisonlevi
force-pushed
the
levi/profiles-dictionary-ffi
branch
from
7e79afb to
6289fee
Compare
morrisonlevi
force-pushed
the
levi/profile-add2-api
branch
from
e7fc7a4 to
0618837
Compare
danielsn
approved these changes
Dec 17, 2025
| // Create a ProfilesDictionary for the new API | ||
| ddog_prof_ProfilesDictionaryHandle dict = {0}; | ||
| ddog_prof_Status dict_status = ddog_prof_ProfilesDictionary_new(&dict); | ||
| if (dict_status.flags != 0) { |
Contributor
There was a problem hiding this comment.
This should probably be a named constant to be clearer
Contributor
Author
There was a problem hiding this comment.
You specifically mean the 0 for the name? It was chosen specifically because environments like Java and sometimes .NET don't get to use the C macros--the detail needs to be concrete.
But we can still add a constant, it just needs to be guaranteed to also be zero or else there could be issues.
To be honest, we could probably simplify this stuff. Rely on null to mean no error, and then use the lowest bit for "allocated or not".
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
levi.morrison@datadoghq.com cancelled this merge request build |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Contributor
Author
|
/merge --cancel |
|
View all feedbacks in Devflow UI.
|
dd-devflow
bot
added
mergequeue-status: retrying
mergequeue-status: removed
and removed
mergequeue-status: in_progress
mergequeue-status: retrying
labels
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds FFI bindings for dictionary-based profiling APIs, which enable more efficient profile creation by pre-registering strings, functions, and mappings in a shared dictionary.
ddog_prof_Profile_with_dictionary: create a profile with aProfilesDictionaryfor string/function/mapping reuse.ddog_prof_Profile_add2: Add samples using dictionary IDs instead of raw strings/pointers.Label2andSample2for ID-based sample construction.Motivation
This completes the FFI layer for the dictionary-based profiling API introduced in earlier PRs. The new APIs allow profiling clients to:
ProfilesDictionaryfor deduplication. This can and should live beyond a minute, possibly forever.StringId2,FunctionId2,MappingId2) instead of raw strings.The C example demonstrates both the old and new APIs side-by-side, showing how to use the dictionary for sample insertion.
Additional Notes
libdd-profiling/benches/add_samples.rs(already inmain) show ~31% overhead for dictionary translation, primarily due to string lookups.profiles.cexample successfully compiles and runs with both APIs.How to test the change?