-
Notifications
You must be signed in to change notification settings - Fork 16
fix(test-agent): undo commenting arg in docker cmd #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Changes The --rm option passed when spawning docker containers was wrongly commented out and merged in a previous commit, leading to containers not being removed after running tests... This PR fixes it
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
- Coverage 71.31% 71.30% -0.02%
==========================================
Files 413 413
Lines 66148 66148
==========================================
- Hits 47174 47164 -10
- Misses 18974 18984 +10
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-01-12 17:31:47 Comparing candidate commit 12a106f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics. scenario:single_flag_killswitch/rules-based
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Changes
The --rm option passed when spawning docker containers was wrongly commented out and merged in a previous commit, leading to containers not being removed after running tests...