feat(stats): propagate service source from span meta to client stats payload#1803
Conversation
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1803 +/- ##
==========================================
+ Coverage 71.01% 71.12% +0.10%
==========================================
Files 411 411
Lines 64803 64989 +186
==========================================
+ Hits 46023 46222 +199
+ Misses 18780 18767 -13
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-03-26 09:43:55 Comparing candidate commit 578796d in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 60 metrics, 0 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 189.979ns | 192.290ns ± 1.900ns | 192.062ns ± 1.120ns | 193.037ns | 195.850ns | 198.262ns | 199.466ns | 3.85% | 1.101 | 1.332 | 0.99% | 0.134ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [192.026ns; 192.553ns] or [-0.137%; +0.137%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | 13.965ms | 14.017ms ± 0.037ms | 14.011ms ± 0.014ms | 14.025ms | 14.066ms | 14.133ms | 14.331ms | 2.28% | 4.016 | 26.836 | 0.26% | 0.003ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | [14.012ms; 14.022ms] or [-0.037%; +0.037%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | 243.595ns | 255.352ns ± 12.277ns | 249.964ns ± 3.911ns | 256.925ns | 282.414ns | 291.997ns | 293.525ns | 17.43% | 1.595 | 1.557 | 4.80% | 0.868ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | [253.651ns; 257.054ns] or [-0.666%; +0.666%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | 740.956µs | 742.049µs ± 0.539µs | 742.047µs ± 0.365µs | 742.367µs | 742.943µs | 743.492µs | 743.597µs | 0.21% | 0.268 | -0.172 | 0.07% | 0.038µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | [741.974µs; 742.124µs] or [-0.010%; +0.010%] | None | None | None |
Group 5
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | 33.809µs | 34.571µs ± 1.377µs | 33.932µs ± 0.044µs | 34.023µs | 37.567µs | 37.585µs | 37.766µs | 11.30% | 1.697 | 0.903 | 3.97% | 0.097µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | [34.380µs; 34.762µs] or [-0.552%; +0.552%] | None | None | None |
Group 6
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | 161.582µs | 162.353µs ± 0.339µs | 162.290µs ± 0.110µs | 162.437µs | 162.798µs | 163.515µs | 165.428µs | 1.93% | 4.323 | 33.747 | 0.21% | 0.024µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | [162.306µs; 162.400µs] or [-0.029%; +0.029%] | None | None | None |
Group 7
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 13.955µs | 14.356µs ± 0.301µs | 14.227µs ± 0.202µs | 14.572µs | 14.768µs | 15.148µs | 16.327µs | 14.76% | 1.755 | 7.841 | 2.09% | 0.021µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [14.314µs; 14.397µs] or [-0.291%; +0.291%] | None | None | None |
Group 8
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | 185.662µs | 186.034µs ± 0.225µs | 186.027µs ± 0.158µs | 186.170µs | 186.371µs | 186.554µs | 187.392µs | 0.73% | 1.290 | 5.395 | 0.12% | 0.016µs | 1 | 200 |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | 5336415.647op/s | 5375361.549op/s ± 6504.088op/s | 5375571.349op/s ± 4558.419op/s | 5380397.463op/s | 5384672.959op/s | 5385953.844op/s | 5386134.689op/s | 0.20% | -1.269 | 5.254 | 0.12% | 459.908op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | execution_time | 17.812µs | 17.893µs ± 0.033µs | 17.891µs ± 0.018µs | 17.911µs | 17.947µs | 17.973µs | 18.016µs | 0.70% | 0.296 | 0.605 | 0.18% | 0.002µs | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | throughput | 55505802.455op/s | 55887917.678op/s ± 103476.472op/s | 55894943.813op/s ± 55766.910op/s | 55944588.530op/s | 56065693.166op/s | 56111390.751op/s | 56140628.973op/s | 0.44% | -0.283 | 0.585 | 0.18% | 7316.892op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/good | execution_time | 10.532µs | 10.576µs ± 0.023µs | 10.571µs ± 0.011µs | 10.589µs | 10.612µs | 10.649µs | 10.713µs | 1.35% | 1.669 | 5.921 | 0.22% | 0.002µs | 1 | 200 |
| normalization/normalize_name/normalize_name/good | throughput | 93345266.326op/s | 94550826.764op/s ± 207570.372op/s | 94602836.014op/s ± 95126.322op/s | 94682664.905op/s | 94784247.180op/s | 94935266.586op/s | 94951067.583op/s | 0.37% | -1.636 | 5.709 | 0.22% | 14677.442op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | [186.003µs; 186.066µs] or [-0.017%; +0.017%] | None | None | None |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | [5374460.145op/s; 5376262.953op/s] or [-0.017%; +0.017%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | execution_time | [17.888µs; 17.898µs] or [-0.026%; +0.026%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | throughput | [55873576.834op/s; 55902258.522op/s] or [-0.026%; +0.026%] | None | None | None |
| normalization/normalize_name/normalize_name/good | execution_time | [10.573µs; 10.580µs] or [-0.031%; +0.031%] | None | None | None |
| normalization/normalize_name/normalize_name/good | throughput | [94522059.507op/s; 94579594.021op/s] or [-0.030%; +0.030%] | None | None | None |
Group 9
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | 2.375µs | 2.428µs ± 0.071µs | 2.403µs ± 0.013µs | 2.418µs | 2.610µs | 2.646µs | 2.649µs | 10.27% | 2.134 | 3.058 | 2.90% | 0.005µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | [2.418µs; 2.438µs] or [-0.403%; +0.403%] | None | None | None |
Group 10
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 144.262µs | 146.209µs ± 1.939µs | 145.929µs ± 0.488µs | 146.396µs | 147.800µs | 152.276µs | 165.998µs | 13.75% | 6.687 | 58.755 | 1.32% | 0.137µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [145.941µs; 146.478µs] or [-0.184%; +0.184%] | None | None | None |
Group 11
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | 4.096ms | 4.103ms ± 0.007ms | 4.102ms ± 0.002ms | 4.104ms | 4.107ms | 4.114ms | 4.199ms | 2.35% | 11.322 | 144.921 | 0.18% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | [4.102ms; 4.104ms] or [-0.025%; +0.025%] | None | None | None |
Group 12
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | 3.896µs | 3.915µs ± 0.003µs | 3.915µs ± 0.002µs | 3.917µs | 3.921µs | 3.924µs | 3.925µs | 0.25% | -0.645 | 5.747 | 0.08% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/ | throughput | 254757763.257op/s | 255395965.007op/s ± 216313.041op/s | 255402640.518op/s ± 123657.592op/s | 255525367.284op/s | 255695966.683op/s | 255768187.785op/s | 256699918.097op/s | 0.51% | 0.664 | 5.849 | 0.08% | 15295.642op/s | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | 79.045µs | 79.921µs ± 0.130µs | 79.928µs ± 0.060µs | 79.990µs | 80.068µs | 80.139µs | 80.431µs | 0.63% | -1.991 | 12.599 | 0.16% | 0.009µs | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | 12433004.852op/s | 12512390.453op/s ± 20486.782op/s | 12511303.617op/s ± 9423.255op/s | 12520055.999op/s | 12542257.142op/s | 12586107.663op/s | 12650952.978op/s | 1.12% | 2.043 | 12.900 | 0.16% | 1448.634op/s | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | execution_time | 67.835µs | 67.955µs ± 0.071µs | 67.950µs ± 0.038µs | 67.988µs | 68.066µs | 68.111µs | 68.548µs | 0.88% | 3.133 | 23.120 | 0.10% | 0.005µs | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | throughput | 14588274.536op/s | 14715600.346op/s ± 15309.284op/s | 14716721.019op/s ± 8207.435op/s | 14724732.323op/s | 14734965.612op/s | 14740494.496op/s | 14741718.615op/s | 0.17% | -3.086 | 22.612 | 0.10% | 1082.530op/s | 1 | 200 |
| credit_card/is_card_number/37828224631 | execution_time | 3.896µs | 3.914µs ± 0.003µs | 3.914µs ± 0.002µs | 3.915µs | 3.918µs | 3.920µs | 3.923µs | 0.24% | -0.937 | 8.754 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/37828224631 | throughput | 254911384.123op/s | 255513127.237op/s ± 178450.883op/s | 255523112.066op/s ± 107335.419op/s | 255619904.946op/s | 255741183.122op/s | 255791224.470op/s | 256693522.201op/s | 0.46% | 0.958 | 8.885 | 0.07% | 12618.383op/s | 1 | 200 |
| credit_card/is_card_number/378282246310005 | execution_time | 64.801µs | 64.906µs ± 0.059µs | 64.897µs ± 0.038µs | 64.939µs | 65.001µs | 65.065µs | 65.103µs | 0.32% | 0.717 | 0.485 | 0.09% | 0.004µs | 1 | 200 |
| credit_card/is_card_number/378282246310005 | throughput | 15360194.581op/s | 15407011.108op/s ± 14041.908op/s | 15409066.476op/s ± 9056.399op/s | 15417278.975op/s | 15426450.848op/s | 15430652.242op/s | 15431783.800op/s | 0.15% | -0.711 | 0.472 | 0.09% | 992.913op/s | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | execution_time | 45.479µs | 45.659µs ± 0.072µs | 45.661µs ± 0.045µs | 45.702µs | 45.780µs | 45.823µs | 45.846µs | 0.41% | -0.004 | -0.123 | 0.16% | 0.005µs | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | throughput | 21812054.253op/s | 21901655.809op/s ± 34570.702op/s | 21900515.812op/s ± 21480.622op/s | 21924097.135op/s | 21959998.559op/s | 21982402.234op/s | 21988111.028op/s | 0.40% | 0.013 | -0.123 | 0.16% | 2444.518op/s | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | execution_time | 6.829µs | 6.836µs ± 0.003µs | 6.836µs ± 0.002µs | 6.838µs | 6.842µs | 6.845µs | 6.846µs | 0.16% | 0.629 | 0.021 | 0.05% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | throughput | 146064806.449op/s | 146288235.905op/s ± 73645.202op/s | 146294294.523op/s ± 45971.805op/s | 146341575.642op/s | 146393075.258op/s | 146409797.539op/s | 146427611.664op/s | 0.09% | -0.627 | 0.017 | 0.05% | 5207.502op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | execution_time | 3.894µs | 3.914µs ± 0.002µs | 3.914µs ± 0.001µs | 3.915µs | 3.917µs | 3.919µs | 3.919µs | 0.12% | -2.556 | 20.456 | 0.06% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | throughput | 255187879.704op/s | 255508610.551op/s ± 155860.757op/s | 255503270.443op/s ± 82911.566op/s | 255588324.941op/s | 255723838.930op/s | 255800114.191op/s | 256781055.005op/s | 0.50% | 2.586 | 20.744 | 0.06% | 11021.020op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | 60.675µs | 65.643µs ± 0.743µs | 65.777µs ± 0.030µs | 65.807µs | 65.845µs | 65.869µs | 65.894µs | 0.18% | -5.743 | 32.747 | 1.13% | 0.053µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | 15175947.254op/s | 15235921.254op/s ± 184457.664op/s | 15202870.381op/s ± 6919.337op/s | 15209464.144op/s | 15228389.822op/s | 16407577.294op/s | 16481307.612op/s | 8.41% | 5.805 | 33.484 | 1.21% | 13043.127op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | 53.350µs | 53.415µs ± 0.032µs | 53.411µs ± 0.018µs | 53.429µs | 53.470µs | 53.523µs | 53.551µs | 0.26% | 1.018 | 2.194 | 0.06% | 0.002µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | 18673680.024op/s | 18721372.773op/s ± 11196.962op/s | 18722821.721op/s ± 6394.621op/s | 18728942.859op/s | 18737485.938op/s | 18741395.936op/s | 18744170.488op/s | 0.11% | -1.013 | 2.175 | 0.06% | 791.745op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | 3.896µs | 3.914µs ± 0.003µs | 3.914µs ± 0.002µs | 3.915µs | 3.918µs | 3.923µs | 3.930µs | 0.42% | 0.135 | 9.686 | 0.08% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | 254420759.778op/s | 255480684.462op/s ± 199864.606op/s | 255490420.159op/s ± 98500.062op/s | 255589763.632op/s | 255707702.820op/s | 255798688.825op/s | 256684337.315op/s | 0.47% | -0.108 | 9.734 | 0.08% | 14132.562op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | 50.144µs | 50.208µs ± 0.033µs | 50.205µs ± 0.020µs | 50.226µs | 50.267µs | 50.314µs | 50.331µs | 0.25% | 0.827 | 1.042 | 0.06% | 0.002µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | 19868587.178op/s | 19917196.343op/s ± 12914.454op/s | 19918436.001op/s ± 7794.107op/s | 19925812.712op/s | 19935102.967op/s | 19937232.211op/s | 19942760.289op/s | 0.12% | -0.822 | 1.028 | 0.06% | 913.190op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | 45.430µs | 45.666µs ± 0.070µs | 45.670µs ± 0.045µs | 45.709µs | 45.765µs | 45.821µs | 45.838µs | 0.37% | -0.209 | 0.272 | 0.15% | 0.005µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | 21816003.824op/s | 21898079.637op/s ± 33570.222op/s | 21896311.114op/s ± 21767.875op/s | 21922742.066op/s | 21955465.098op/s | 21979018.180op/s | 22012075.825op/s | 0.53% | 0.219 | 0.281 | 0.15% | 2373.773op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | 6.821µs | 6.836µs ± 0.004µs | 6.835µs ± 0.003µs | 6.838µs | 6.843µs | 6.846µs | 6.856µs | 0.30% | 0.686 | 2.849 | 0.06% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | 145865554.034op/s | 146288422.656op/s ± 87354.772op/s | 146296415.738op/s ± 54166.801op/s | 146346172.218op/s | 146410109.190op/s | 146454678.994op/s | 146611020.619op/s | 0.22% | -0.678 | 2.830 | 0.06% | 6176.915op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | [3.915µs; 3.916µs] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number/ | throughput | [255365986.100op/s; 255425943.915op/s] or [-0.012%; +0.012%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | [79.903µs; 79.939µs] or [-0.023%; +0.023%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | [12509551.183op/s; 12515229.724op/s] or [-0.023%; +0.023%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | execution_time | [67.945µs; 67.965µs] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | throughput | [14713478.626op/s; 14717722.065op/s] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/37828224631 | execution_time | [3.913µs; 3.914µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/37828224631 | throughput | [255488395.661op/s; 255537858.814op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number/378282246310005 | execution_time | [64.897µs; 64.914µs] or [-0.013%; +0.013%] | None | None | None |
| credit_card/is_card_number/378282246310005 | throughput | [15405065.035op/s; 15408957.181op/s] or [-0.013%; +0.013%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | execution_time | [45.649µs; 45.669µs] or [-0.022%; +0.022%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | throughput | [21896864.642op/s; 21906446.975op/s] or [-0.022%; +0.022%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | execution_time | [6.835µs; 6.836µs] or [-0.007%; +0.007%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | throughput | [146278029.389op/s; 146298442.422op/s] or [-0.007%; +0.007%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | execution_time | [3.913µs; 3.914µs] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | throughput | [255487009.749op/s; 255530211.353op/s] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | [65.540µs; 65.746µs] or [-0.157%; +0.157%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | [15210357.196op/s; 15261485.312op/s] or [-0.168%; +0.168%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | [53.410µs; 53.419µs] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | [18719820.982op/s; 18722924.565op/s] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | [3.914µs; 3.915µs] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | [255452985.150op/s; 255508383.774op/s] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | [50.203µs; 50.212µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | [19915406.524op/s; 19918986.162op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | [45.657µs; 45.676µs] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | [21893427.127op/s; 21902732.147op/s] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | [6.835µs; 6.836µs] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | [146276316.125op/s; 146300529.187op/s] or [-0.008%; +0.008%] | None | None | None |
Group 13
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | 48.809ms | 49.110ms ± 1.021ms | 48.955ms ± 0.041ms | 49.013ms | 49.340ms | 51.597ms | 59.720ms | 21.99% | 9.180 | 86.567 | 2.07% | 0.072ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | [48.968ms; 49.251ms] or [-0.288%; +0.288%] | None | None | None |
Group 14
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | 4.137ms | 4.141ms ± 0.002ms | 4.141ms ± 0.001ms | 4.142ms | 4.145ms | 4.147ms | 4.154ms | 0.33% | 1.387 | 4.723 | 0.06% | 0.000ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | [4.141ms; 4.141ms] or [-0.008%; +0.008%] | None | None | None |
Group 15
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | 285.543µs | 286.203µs ± 0.486µs | 286.119µs ± 0.105µs | 286.249µs | 286.643µs | 288.778µs | 290.139µs | 1.40% | 5.277 | 35.184 | 0.17% | 0.034µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | [286.135µs; 286.270µs] or [-0.024%; +0.024%] | None | None | None |
Group 16
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_serialize_compressed_pprof_timestamped_x1000 | execution_time | 919.144µs | 921.187µs ± 1.885µs | 921.054µs ± 0.710µs | 921.681µs | 922.850µs | 923.919µs | 943.582µs | 2.45% | 8.455 | 97.886 | 0.20% | 0.133µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_serialize_compressed_pprof_timestamped_x1000 | execution_time | [920.926µs; 921.449µs] or [-0.028%; +0.028%] | None | None | None |
Group 17
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | 495.433µs | 496.259µs ± 0.376µs | 496.243µs ± 0.284µs | 496.547µs | 496.854µs | 497.114µs | 497.560µs | 0.27% | 0.279 | -0.223 | 0.08% | 0.027µs | 1 | 200 |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | 2009807.414op/s | 2015078.330op/s ± 1527.189op/s | 2015143.016op/s ± 1155.295op/s | 2016245.845op/s | 2017415.293op/s | 2018058.844op/s | 2018438.209op/s | 0.16% | -0.275 | -0.229 | 0.08% | 107.989op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | 370.264µs | 371.054µs ± 0.385µs | 371.022µs ± 0.242µs | 371.294µs | 371.662µs | 371.806µs | 373.720µs | 0.73% | 1.733 | 10.130 | 0.10% | 0.027µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | 2675796.640op/s | 2695027.344op/s ± 2787.975op/s | 2695254.331op/s ± 1761.345op/s | 2696942.781op/s | 2698982.785op/s | 2700199.143op/s | 2700777.566op/s | 0.20% | -1.705 | 9.898 | 0.10% | 197.140op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | 168.047µs | 168.416µs ± 0.195µs | 168.401µs ± 0.130µs | 168.532µs | 168.782µs | 168.860µs | 169.077µs | 0.40% | 0.497 | 0.100 | 0.12% | 0.014µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | 5914465.007op/s | 5937692.170op/s ± 6858.363op/s | 5938191.847op/s ± 4573.134op/s | 5942503.727op/s | 5948601.853op/s | 5949977.389op/s | 5950703.816op/s | 0.21% | -0.491 | 0.089 | 0.12% | 484.959op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | 36.798µs | 36.963µs ± 0.120µs | 36.920µs ± 0.080µs | 37.064µs | 37.181µs | 37.245µs | 37.252µs | 0.90% | 0.589 | -0.839 | 0.32% | 0.008µs | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | throughput | 26844450.874op/s | 27054100.673op/s ± 87455.614op/s | 27085623.500op/s ± 59025.213op/s | 27129707.419op/s | 27157770.662op/s | 27168471.577op/s | 27175252.880op/s | 0.33% | -0.581 | -0.853 | 0.32% | 6184.046op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | 46.253µs | 46.384µs ± 0.046µs | 46.385µs ± 0.029µs | 46.411µs | 46.459µs | 46.508µs | 46.546µs | 0.35% | 0.468 | 0.942 | 0.10% | 0.003µs | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | 21484113.307op/s | 21559096.499op/s ± 21241.118op/s | 21558681.049op/s ± 13388.651op/s | 21574204.767op/s | 21590319.235op/s | 21599531.953op/s | 21620349.910op/s | 0.29% | -0.460 | 0.928 | 0.10% | 1501.974op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | [496.207µs; 496.311µs] or [-0.011%; +0.011%] | None | None | None |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | [2014866.676op/s; 2015289.984op/s] or [-0.011%; +0.011%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | [371.001µs; 371.107µs] or [-0.014%; +0.014%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | [2694640.957op/s; 2695413.730op/s] or [-0.014%; +0.014%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | [168.389µs; 168.443µs] or [-0.016%; +0.016%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | [5936741.667op/s; 5938642.674op/s] or [-0.016%; +0.016%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | [36.947µs; 36.980µs] or [-0.045%; +0.045%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | throughput | [27041980.166op/s; 27066221.180op/s] or [-0.045%; +0.045%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | [46.378µs; 46.391µs] or [-0.014%; +0.014%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | [21556152.685op/s; 21562040.314op/s] or [-0.014%; +0.014%] | None | None | None |
Group 18
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | 3.400ms | 3.441ms ± 0.026ms | 3.432ms ± 0.011ms | 3.449ms | 3.504ms | 3.518ms | 3.524ms | 2.67% | 1.489 | 1.624 | 0.75% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | [3.438ms; 3.445ms] or [-0.104%; +0.104%] | None | None | None |
Group 19
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | 4.961µs | 5.046µs ± 0.051µs | 5.044µs ± 0.050µs | 5.083µs | 5.126µs | 5.130µs | 5.130µs | 1.72% | 0.259 | -1.221 | 1.01% | 0.004µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | [5.039µs; 5.053µs] or [-0.140%; +0.140%] | None | None | None |
Group 20
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 5.447µs | 5.652µs ± 0.029µs | 5.650µs ± 0.014µs | 5.664µs | 5.704µs | 5.749µs | 5.763µs | 2.01% | -0.721 | 12.883 | 0.52% | 0.002µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [5.648µs; 5.656µs] or [-0.072%; +0.072%] | None | None | None |
Group 21
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 578796d | 1774517213 | andrea.marziali/stat-service-source |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 14.744ms | 14.769ms ± 0.014ms | 14.767ms ± 0.008ms | 14.777ms | 14.795ms | 14.807ms | 14.829ms | 0.42% | 0.922 | 1.196 | 0.09% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [14.767ms; 14.771ms] or [-0.013%; +0.013%] | None | None | None |
Baseline
Omitted due to size.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 578796d | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
raphaelgavache
left a comment
There was a problem hiding this comment.
is the encoding of the payload done by tracers?
No it's done by serde based on the struct generated from the protobuf definition here |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
5cfc694
into
main
What does this PR do?
Implements the client stats part of the Service Override Source Attribution RFC
_dd.svc_srcfrom span metadata and includes it in theClientGroupedStats.service_source(srv_src) field of the stats payloadservice_sourceto the aggregation key so spans with different service override origins are bucketed separatelyMotivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.