chore(ci): run macOS jobs in GitLab for MergeQueue. Remove broken label rule#1833
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom Apr 1, 2026
Conversation
ekump
changed the title
brettlangdon
approved these changes
Apr 1, 2026
| when: always | ||
| - if: '$CI_EXTERNAL_PULL_REQUEST_SOURCE_BRANCH_NAME =~ /^release\//' | ||
| when: always | ||
| - if: '$CI_MERGE_REQUEST_LABELS =~ /run-macos-tests/' |
Member
There was a problem hiding this comment.
yeah, this doesn't work, we don't use GitLab merge requests, have to ping GitHub API to get this data from the PR
ekump
force-pushed
the
ekump/APMSP-2796-enable-macos-jobs-for-mergequeue
branch
from
efd033e to
a4c9289
Compare
yannham
approved these changes
Apr 1, 2026
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: a4c9289 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1833 +/- ##
==========================================
+ Coverage 71.50% 71.54% +0.04%
==========================================
Files 426 426
Lines 67072 67072
==========================================
+ Hits 47957 47987 +30
+ Misses 19115 19085 -30
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
bot
deleted the
ekump/APMSP-2796-enable-macos-jobs-for-mergequeue
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now that we have dedicated MacOS runners (https://github.com/DataDog/libddprof-build/pull/166) in GitLab, contention with the general pool is not an issue. We should be running the MacOS tests on the MergeQueue to prevent bad mac merges to main.
Using the
run-macos-testslabel in Github to trigger the jobs in GitLab for PRs didn't (ever?) work. So just getting rid of it. Assuming things work out well with the dedicated runners we can consider upping the allocation of runners and just running macOS builds on all PRs.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.