fix(crashtracking): handle new lines in client submitted exception message#1836
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom Apr 1, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gyuheon0h
changed the title
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 984afb9 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## gyuheon0h/fix-stale-prebuild #1836 +/- ##
================================================================
- Coverage 71.50% 71.48% -0.03%
================================================================
Files 426 426
Lines 67096 67100 +4
================================================================
- Hits 47978 47965 -13
- Misses 19118 19135 +17
🚀 New features to boost your workflow:
|
Contributor
Author
|
Gonna verify end to end before merging this |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
gyuheon.oh@datadoghq.com cancelled this merge request build |
gh-worker-dd-devflow-36fce6
bot
added
mergequeue-status: rejected
and removed
mergequeue-status: in_progress
labels
gyuheon0h
force-pushed
the
gyuheon0h/PROF-14177-handle-newline-msg
branch
from
18e5402 to
70768f7
Compare
gyuheon0h
force-pushed
the
gyuheon0h/PROF-14177-handle-newline-msg
branch
from
70768f7 to
1aa5b50
Compare
gyuheon0h
changed the base branch from
graphite-base/1836
to
gyuheon0h/fix-stale-prebuild
gyuheon0h
force-pushed
the
gyuheon0h/PROF-14177-handle-newline-msg
branch
from
1aa5b50 to
984afb9
Compare
gh-worker-dd-mergequeue-cf854d
bot
requested a review
from a team
as a code owner
gh-worker-dd-mergequeue-cf854d
bot
deleted the
gyuheon0h/PROF-14177-handle-newline-msg
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Escapes new lines from API consumer submitted unhandled exception message, then unescapes it when writing the report. This is necessary, because API consumers can submit arbitrary exception messages, and if they contain new lines, the receiver state machine parsing breaks as it depends on chunks of data being sent as lines.
Motivation
This crash log has no message because the exception message being sent has new lines in it
Additional Notes
I've looked at other places where API consumers submit raw strings that we just pass in raw, and I cannot find other plausible places where this could be an issue
How to test the change?
Bin_test updated to include a new line in the input to the unhandled exception API