fix(ci): skip thread counting test by gyuheon0h · Pull Request #1841 · DataDog/libdatadog

gyuheon0h · 2026-04-02T14:04:20Z

What does this PR do?

test_count_active_threads run on centos7 are flaking as such:

stdout ───

    running 1 test

    running 1 test

    thread 'test_utils::tests::test_count_active_threads' (70243) panicked at libdd-common/src/test_utils.rs:564:13:
    Expected thread count to return to 2 or 3 after join, got 4
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    test test_utils::tests::test_count_active_threads ... FAILED

    failures:

    failures:
        test_utils::tests::test_count_active_threads

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 112 filtered out; finished in 0.05s

  stderr ───

    thread 'test_utils::tests::test_count_active_threads' (70241) panicked at /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rusty-fork-0.3.1/src/fork_test.rs:135:9:
    child exited unsuccessfully with exit status: 70
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This is because some platforms, such as CentOS, spawn helper threads

Motivation

Its been extremely flaky over the past two months

Additional Notes

This test test a helper that is used for another test. The actual thread counting functionality seems sound, but the testing of thread counting with hard assertions on the # of threads is flaky because it is dependent on platform and sync state

How to test the change?

Describe here in detail how the change can be validated.

gyuheon0h · 2026-04-02T14:04:36Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-02T14:07:14Z

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

Base Branch: origin/main
PR Branch: origin/gyuheon0h/relax-post-join-thread-check

Summary by Rule

Rule	Base Branch	PR Branch	Change

Annotation Counts by File

File	Base Branch	PR Branch	Change

Annotation Stats by Crate

Crate	Base Branch	PR Branch	Change
`clippy-annotation-reporter`	5	5	No change (0%)
`datadog-ffe-ffi`	1	1	No change (0%)
`datadog-ipc`	21	21	No change (0%)
`datadog-live-debugger`	6	6	No change (0%)
`datadog-live-debugger-ffi`	10	10	No change (0%)
`datadog-profiling-replayer`	4	4	No change (0%)
`datadog-remote-config`	3	3	No change (0%)
`datadog-sidecar`	55	55	No change (0%)
`libdd-common`	10	10	No change (0%)
`libdd-common-ffi`	12	12	No change (0%)
`libdd-data-pipeline`	5	5	No change (0%)
`libdd-ddsketch`	2	2	No change (0%)
`libdd-dogstatsd-client`	1	1	No change (0%)
`libdd-profiling`	13	13	No change (0%)
`libdd-telemetry`	19	19	No change (0%)
`libdd-tinybytes`	4	4	No change (0%)
`libdd-trace-normalization`	2	2	No change (0%)
`libdd-trace-obfuscation`	8	8	No change (0%)
`libdd-trace-utils`	15	15	No change (0%)
Total	196	196	No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

codecov-commenter · 2026-04-02T14:17:11Z

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.49%. Comparing base (eb3c39b) to head (dd8412e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
- Coverage   71.60%   71.49%   -0.11%     
==========================================
  Files         426      426              
  Lines       67302    67303       +1     
==========================================
- Hits        48194    48121      -73     
- Misses      19108    19182      +74

Components	Coverage Δ
libdd-crashtracker	`65.93% <ø> (-0.05%)`	⬇️
libdd-crashtracker-ffi	`34.09% <ø> (ø)`
libdd-alloc	`98.77% <ø> (ø)`
libdd-data-pipeline	`86.20% <ø> (ø)`
libdd-data-pipeline-ffi	`72.22% <ø> (ø)`
libdd-common	`79.16% <0.00%> (-0.85%)`	⬇️
libdd-common-ffi	`73.87% <ø> (ø)`
libdd-telemetry	`62.80% <ø> (ø)`
libdd-telemetry-ffi	`16.75% <ø> (ø)`
libdd-dogstatsd-client	`82.64% <ø> (ø)`
datadog-ipc	`71.00% <ø> (-2.04%)`	⬇️
libdd-profiling	`82.04% <ø> (-0.02%)`	⬇️
libdd-profiling-ffi	`64.94% <ø> (ø)`
datadog-sidecar	`31.18% <ø> (ø)`
datdog-sidecar-ffi	`11.84% <ø> (ø)`
spawn-worker	`54.69% <ø> (ø)`
libdd-tinybytes	`93.16% <ø> (ø)`
libdd-trace-normalization	`81.71% <ø> (ø)`
libdd-trace-obfuscation	`87.24% <ø> (ø)`
libdd-trace-protobuf	`68.25% <ø> (ø)`
libdd-trace-utils	`88.73% <ø> (ø)`
datadog-tracer-flare	`86.88% <ø> (ø)`
libdd-log	`74.69% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

datadog-prod-us1-3 · 2026-04-02T14:17:46Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 71.50% (-0.11%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: dd8412e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}

libdd-common/src/test_utils.rs

gyuheon0h · 2026-04-02T14:35:17Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-04-02T14:35:21Z

View all feedbacks in Devflow UI.

2026-04-02 14:35:21 UTC ℹ️ Start processing command /merge

2026-04-02 14:35:28 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-04-02 15:14:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-04-02 15:52:20 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit b2ac6a4:

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

dd-octo-sts · 2026-04-02T15:13:24Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	102.14 MB	102.14 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	8.76 MB	8.76 MB	0% (0 B) 👌

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	119.15 MB	119.15 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	11.37 MB	11.37 MB	0% (0 B) 👌

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	27.42 MB	27.42 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	80.69 KB	80.69 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	187.86 MB	187.86 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	924.71 MB	924.71 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	9.06 MB	9.06 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	80.69 KB	80.69 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	27.01 MB	27.01 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	61.33 MB	61.33 MB	0% (0 B) 👌

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	23.27 MB	23.27 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	81.94 KB	81.94 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	192.41 MB	192.40 MB	-0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	909.85 MB	909.85 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	6.90 MB	6.90 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	81.94 KB	81.94 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	29.12 MB	29.12 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	57.70 MB	57.70 MB	0% (0 B) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	88.99 MB	88.99 MB	0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	10.34 MB	10.34 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	111.80 MB	111.80 MB	0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	12.10 MB	12.10 MB	0% (0 B) 👌

gyuheon0h · 2026-04-02T15:53:19Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-04-02T15:53:24Z

View all feedbacks in Devflow UI.

2026-04-02 15:53:24 UTC ℹ️ Start processing command /merge

2026-04-02 15:53:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-04-02 16:38:33 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit f66012f:

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

TRIGGER CI

gyuheon0h · 2026-04-02T20:50:09Z

surely this will merge after 6 mq failures

ekump · 2026-04-03T13:22:22Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-04-03T13:22:26Z

View all feedbacks in Devflow UI.

2026-04-03 13:22:26 UTC ℹ️ Start processing command /merge

2026-04-03 13:22:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-04-03 14:03:19 UTC ℹ️ MergeQueue: This merge request was merged

github-actions bot added the common label Apr 2, 2026

gyuheon0h changed the title ~~Relax post join thread count check~~ fix(ci): relax post join thread count check Apr 2, 2026

gyuheon0h marked this pull request as ready for review April 2, 2026 14:14

gyuheon0h requested a review from a team as a code owner April 2, 2026 14:14

gyuheon0h force-pushed the gyuheon0h/relax-post-join-thread-check branch from 7636271 to 90f9e53 Compare April 2, 2026 14:22

gyuheon0h changed the title ~~fix(ci): relax post join thread count check~~ fix(ci): skip thread counting test Apr 2, 2026

gyuheon0h force-pushed the gyuheon0h/relax-post-join-thread-check branch from 90f9e53 to 3f37870 Compare April 2, 2026 14:27

gyuheon0h requested review from Aaalibaba42 and ekump April 2, 2026 14:28

Aaalibaba42 approved these changes Apr 2, 2026

View reviewed changes

libdd-common/src/test_utils.rs Outdated Show resolved Hide resolved

ekump approved these changes Apr 2, 2026

View reviewed changes

gyuheon0h force-pushed the gyuheon0h/relax-post-join-thread-check branch from 3f37870 to 45bd86a Compare April 2, 2026 14:34

gh-worker-dd-devflow-36fce6 bot added the mergequeue-status: waiting label Apr 2, 2026

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress labels Apr 2, 2026

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: queued and removed mergequeue-status: rejected labels Apr 2, 2026

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: rejected mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: in_progress mergequeue-status: rejected mergequeue-status: waiting labels Apr 2, 2026

gyuheon0h force-pushed the gyuheon0h/relax-post-join-thread-check branch from b5c6154 to eba8714 Compare April 2, 2026 20:48

Relax post join thread count check

ce1ff18

TRIGGER CI

gyuheon0h force-pushed the gyuheon0h/relax-post-join-thread-check branch from eba8714 to ce1ff18 Compare April 2, 2026 20:49

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: removed mergequeue-status: waiting labels Apr 2, 2026

trigger CI

dd8412e

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: removed mergequeue-status: waiting labels Apr 3, 2026

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: removed mergequeue-status: queued labels Apr 3, 2026

gh-worker-dd-mergequeue-cf854d bot merged commit 4360dbb into main Apr 3, 2026
142 checks passed

gh-worker-dd-devflow-36fce6 bot removed the mergequeue-status: in_progress label Apr 3, 2026

gh-worker-dd-mergequeue-cf854d bot deleted the gyuheon0h/relax-post-join-thread-check branch April 3, 2026 14:03

gh-worker-dd-devflow-36fce6 bot added the mergequeue-status: done label Apr 3, 2026

dd-octo-sts bot mentioned this pull request Apr 10, 2026

chore(release): proposal for libdd-common #1863

Closed

Conversation

gyuheon0h commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

How to test the change?

Uh oh!

gyuheon0h commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Clippy Allow Annotation Report

Summary by Rule

Annotation Counts by File

Annotation Stats by Crate

About This Report

Uh oh!

codecov-commenter commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

datadog-prod-us1-3 bot commented Apr 2, 2026 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gyuheon0h commented Apr 2, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

dd-octo-sts bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

gyuheon0h commented Apr 2, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

gyuheon0h commented Apr 2, 2026

Uh oh!

ekump commented Apr 3, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gyuheon0h commented Apr 2, 2026 •

edited

Loading

gyuheon0h commented Apr 2, 2026 •

edited

Loading

github-actions bot commented Apr 2, 2026 •

edited

Loading

codecov-commenter commented Apr 2, 2026 •

edited

Loading

datadog-prod-us1-3 bot commented Apr 2, 2026 •

edited by datadog-datadog-prod-us1 bot

Loading

gh-worker-devflow-routing-ef8351 bot commented Apr 2, 2026 •

edited

Loading

dd-octo-sts bot commented Apr 2, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Apr 2, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Apr 3, 2026 •

edited

Loading