Skip to content

chore(libdd-crashtracker): remove path reference for libdd-libunwind-sys#1877

Merged
hoolioh merged 2 commits intomainfrom
julio/crashtracker-remove-path-reference
Apr 15, 2026
Merged

chore(libdd-crashtracker): remove path reference for libdd-libunwind-sys#1877
hoolioh merged 2 commits intomainfrom
julio/crashtracker-remove-path-reference

Conversation

@hoolioh
Copy link
Copy Markdown
Contributor

@hoolioh hoolioh commented Apr 14, 2026

What does this PR do?

Remove libdd-libunwind-sys path reference.

Motivation

Since libdd-libunwind-sys is being moved to another repo the path reference is no longer needed.

@hoolioh hoolioh requested a review from a team as a code owner April 14, 2026 12:50
@hoolioh hoolioh marked this pull request as draft April 14, 2026 12:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

📚 Documentation Check Results

⚠️ 1059 documentation warning(s) found

📦 libdd-crashtracker - 1059 warning(s)

Updated: 2026-04-14 13:30:25 UTC | Commit: 818cc5d | missing-docs job results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

🔒 Cargo Deny Results

⚠️ 1 issue(s) found, showing only errors (advisories, bans, sources)

📦 libdd-crashtracker - 1 error(s)

Show output 
error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:144:1
    │
144 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
      
      Affected versions of `rand` are `>= 0.7, < 0.9.3` and `0.10.0`.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── libdd-common v3.0.2
      │   ├── (build) libdd-crashtracker v1.0.0
      │   ├── libdd-shared-runtime v0.1.0
      │   │   └── libdd-telemetry v4.0.0
      │   │       └── libdd-crashtracker v1.0.0 (*)
      │   └── libdd-telemetry v4.0.0 (*)
      └── libdd-crashtracker v1.0.0 (*)

advisories FAILED, bans ok, sources ok

Updated: 2026-04-14 13:31:59 UTC | Commit: 818cc5d | dependency-check job results

@hoolioh hoolioh force-pushed the julio/crashtracker-remove-path-reference branch from 998107b to a768263 Compare April 14, 2026 13:02
@datadog-official
Copy link
Copy Markdown

datadog-official bot commented Apr 14, 2026 •
edited by datadog-datadog-prod-us1 bot
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.83% (+0.06%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c295d64 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.82%. Comparing base (1701392) to head (c295d64).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   71.81%   71.82%   +0.01%     
==========================================
  Files         429      427       -2     
  Lines       68082    67995      -87     
==========================================
- Hits        48891    48840      -51     
+ Misses      19191    19155      -36
Components Coverage Δ
libdd-crashtracker 66.19% <ø> (+0.04%) ⬆️
libdd-crashtracker-ffi 35.75% <ø> (+0.38%) ⬆️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 86.23% <ø> (ø)
libdd-data-pipeline-ffi 72.95% <ø> (ø)
libdd-common 79.16% <ø> (ø)
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 65.98% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 73.10% <ø> (ø)
libdd-profiling 81.62% <ø> (ø)
libdd-profiling-ffi 64.94% <ø> (ø)
datadog-sidecar 31.29% <ø> (+0.50%) ⬆️
datdog-sidecar-ffi 12.36% <ø> (+2.39%) ⬆️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.24% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.24% <ø> (ø)
datadog-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hoolioh hoolioh force-pushed the julio/crashtracker-remove-path-reference branch from a768263 to c295d64 Compare April 14, 2026 13:29
@hoolioh hoolioh marked this pull request as ready for review April 14, 2026 13:49
@hoolioh hoolioh requested a review from a team as a code owner April 14, 2026 13:49
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 14, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.63 MB 7.63 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 83.25 MB 83.27 MB +.02% (+17.71 KB) 🔍
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.30 MB 99.32 MB +.01% (+19.09 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.10 MB 10.10 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.16 MB 25.16 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 78.21 KB 78.21 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.21 MB 184.23 MB +0% (+16.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.12 MB 917.12 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 7.88 MB 7.88 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 78.21 KB 78.21 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.64 MB 23.64 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 46.13 MB 46.13 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.63 MB 21.63 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 79.42 KB 79.42 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.33 MB 188.34 MB +0% (+16.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 902.23 MB 902.23 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.12 MB 6.12 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 79.42 KB 79.42 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 25.31 MB 25.31 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 43.60 MB 43.60 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.38 MB 74.38 MB +0% (+2.85 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.51 MB 8.51 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.67 MB 91.68 MB +.01% (+17.99 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.18 MB 10.18 MB -0% (-8 B) 👌

yannham
yannham reviewed Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see local references of libdd-libunwind-sys in the Dockerfile.build file. Is that ok?

@hoolioh
Copy link
Copy Markdown
Contributor Author

hoolioh commented Apr 15, 2026

I still see local references of libdd-libunwind-sys in the Dockerfile.build file. Is that ok?

When the migration is fully finished a subsequent PR will follow this one removing libdd-libunwind-sys and their presence in the build scripts.

@hoolioh hoolioh merged commit c684b2e into main Apr 15, 2026
57 checks passed
@hoolioh hoolioh deleted the julio/crashtracker-remove-path-reference branch April 15, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yannham yannham yannham approved these changes

@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

crashtracker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoolioh @codecov-commenter @yannham @gleocadie