chore(ci): adds a cron on all actions running a tests#1923
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
+ Coverage 71.69% 71.77% +0.07%
==========================================
Files 434 434
Lines 69951 69978 +27
==========================================
+ Hits 50154 50225 +71
+ Misses 19797 19753 -44
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c74a50dc7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ekump
reviewed
Apr 27, 2026
| branches: | ||
| - main | ||
| schedule: | ||
| - cron: '0 6 * * *' |
Contributor
There was a problem hiding this comment.
This is 1am ET / 7am CET, which guarantees no one will be around if it fails. I assume that's ok?
Contributor
Author
There was a problem hiding this comment.
Yes, trying to not use CPU when they are needed. And it's fine if they fail, the Green CI SLI will track this as any other run.
ekump
approved these changes
Apr 27, 2026
Contributor
ekump
left a comment
ekump
left a comment
There was a problem hiding this comment.
I'm not sure I fully understand what problem this is solving, but I see no harm in it, if it's a precautionary measure. LGTM.
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
merged commit 81c1fa5
into
main
113 of 119 checks passed
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Per title
Motivation
Few months ago, dd-trace-java drops by accident two thirds of its test base. Twice.
Following this incidents, we realized that with our growing test base, it was relatively easy to drop a part of it, as a green CI is always a trigger of "don't check anymore" (which is fine). So we implemented a safe guard on test optim that triggers an alert if ever a repo does does not report its tests to Test Optim. And this monitor caught one other occurences few weeks later ...
The caveats is that we do not have any reliable way to trigger it : once a commit is pushed, we can wait for several minutes, even hours before having all the tests reported. So we implemented it with a compromise : every day we must have the full test base. In consequences, we need to have a schedule that run the test base once a day (including WE, limitation of datadog monitors) , to avoid triggering an alert for days that does not have any commit.
I also adapted the concurrency clause to have all runs runnings on pushes on
mainAdditional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.