feat!: added regex-lite feature#1939
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intoMay 6, 2026
Merged
Conversation
Aaalibaba42
requested review from
leoromanovsky and
typotter
and removed request for
a team
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
yannham
approved these changes
Apr 30, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8a6255c3b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
==========================================
- Coverage 71.73% 71.73% -0.01%
==========================================
Files 434 434
Lines 70395 70454 +59
==========================================
+ Hits 50497 50538 +41
- Misses 19898 19916 +18
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 0b6f61c | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
dd-oleksii
requested changes
Apr 30, 2026
Aaalibaba42
force-pushed
the
jwiriath/conditional-regex-lite
branch
2 times, most recently
from
2691365 to
3524857
Compare
Aaalibaba42
force-pushed
the
jwiriath/conditional-regex-lite
branch
2 times, most recently
from
d68ac17 to
008d103
Compare
…mon provided regex engine, which changes based on the feature chore: use shorthand and format fix: exclude datadog-ffe from this change. feat: remove env_filter and regex-automata docs: remove misleading doc
Aaalibaba42
force-pushed
the
jwiriath/conditional-regex-lite
branch
from
cb43b8c to
9e850dc
Compare
dd-oleksii
reviewed
May 5, 2026
dd-oleksii
approved these changes
May 5, 2026
VianneyRuhlmann
approved these changes
May 6, 2026
Contributor
VianneyRuhlmann
left a comment
VianneyRuhlmann
left a comment
There was a problem hiding this comment.
few nits but LGTM
| @@ -4,10 +4,10 @@ | |||
| use crate::writers::{FileWriter, StdWriter}; | |||
Contributor
There was a problem hiding this comment.
Are these changes linked to the regex changes ?
Contributor
Author
There was a problem hiding this comment.
Yes we needed to move out of EnvFilter to remove regex from transitive dependancies.
| [dependencies] | ||
| tracing = { version = "0.1", default-features = false, features = ["std"] } | ||
| tracing-subscriber = { version = "0.3.22", default-features = false, features = ["json", "env-filter"] } | ||
| tracing-subscriber = { version = "0.3.22", default-features = false, features = ["json"] } |
Contributor
There was a problem hiding this comment.
Is this linked to the regex changes ?
Contributor
Author
There was a problem hiding this comment.
Yes, tracing subscriber used regex automata which depended on regex
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
jwiriath/conditional-regex-lite
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
added regex-lite feature and changed code path to use libdd-common provided regex engine, which changes based on the feature.
Motivation
Improve binary size at the cost of performance.
Additional Notes
There is 1 place in tests in which we use regex crate directly, it's a dev dependancy, shouldn't be a problem.
How to test the change?
cargo metadata to make sure we don't have regex with the feature, look at binary size etc.