ci: harden rustfmt auto workflow against PR token abuse#1971
Merged
Conversation
Signed-off-by: paullegranddc <paul.legranddescloizeaux@datadoghq.com>
paullegranddc
force-pushed
the
codex/fix-vulnerability-in-rustfmt-workflow
branch
from
a6d4276 to
f82946a
Compare
hoolioh
approved these changes
May 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
- Coverage 72.64% 72.59% -0.06%
==========================================
Files 448 450 +2
Lines 73629 73733 +104
==========================================
+ Hits 53487 53523 +36
- Misses 20142 20210 +68
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 41f1e6f | Docs | Datadog PR Page | Give us feedback! |
ekump
approved these changes
May 11, 2026
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
yannham
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pull_request-triggered workflow could mint a write GitHub App token for PR-controlled runs and be retriggered on pushes after a label was applied.synchronizeevents from gaining access to repositorycontents: writecredentials via therustfmt-autojob.Description
synchronizeevent fromon: pull_requestso labeled PRs are not automatically re-run on subsequent pushes.ifcondition:github.event.pull_request.head.repo.full_name == github.repositoryto block fork PR heads from exercising the write-token flow.repository: ${{ github.event.pull_request.head.repo.full_name }}andref: ${{ github.event.pull_request.head.ref }}to avoid ambiguous branch-only checkouts.Testing
sed -n '1,220p' .github/workflows/rustfmt-auto.ymland confirmed the trigger and guard changes, which succeeded.git diff -- .github/workflows/rustfmt-auto.ymlto ensure only the intended workflow hardening edits were made, which succeeded.git addandgit committo record the fix, which succeeded.Codex Task