fix(ci): restore protected-branch constraints for STS policies#1972
Merged
paullegranddc merged 1 commit intoMay 11, 2026
Merged
Conversation
hoolioh
approved these changes
May 11, 2026
Signed-off-by: paullegranddc <paul.legranddescloizeaux@datadoghq.com>
eddb362 to
708e2d6
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: 708e2d6 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
=======================================
Coverage 72.64% 72.64%
=======================================
Files 448 448
Lines 73629 73629
=======================================
Hits 53487 53487
Misses 20142 20142
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
claim_pattern.refto allow unprotected personal branches and commented outref_protected, enabling untrusted branch runs to mint privileged tokens for repository write and org-membership reads, so the trust boundary must be restored.Description
claim_pattern.refback torefs/heads/(main|release)in.github/chainguard/self.write.pr.sts.yamland.github/chainguard/self.read.members.sts.yaml.claim_pattern.ref_protected: "true"in both STS policy files so only protected refs can obtain these tokens.Testing
sed -n '1,200p'to confirm therefandref_protectedvalues were restored and the file contents are correct, and the command succeeded.nl -bato verify the exact lines of theclaim_patternandref_protectedentries, and the command succeeded.main/releaserefs, and this check succeeded.Codex Task