test(ffe): use canonical fixtures by leoromanovsky · Pull Request #1979 · DataDog/libdatadog

leoromanovsky · 2026-05-12T16:40:41Z

Motivation

Use DataDog/ffe-system-test-data as libdatadog's canonical FFE/OpenFeature JSON fixture source instead of keeping local copied fixtures.

Changes and Decisions

Add datadog-ffe/ffe-system-test-data as a submodule pinned to merged canonical main commit 4446371bc1ca52bd526356927ef42d380145b118; remove copied datadog-ffe/tests/data fixtures.
Point datadog-ffe tests, benches, the UFC parse test, and the FFI harness at canonical ufc-config.json and evaluation-cases/*.json, with paths anchored from CARGO_MANIFEST_DIR.
Assert canonical fixture values only. result.reason stays out of scope while reason behavior is still evolving.
Initialize submodules in FFI and benchmark CI checkouts so the fixture files exist where those jobs run.
Add CODEOWNERS coverage for .gitmodules and weekly Dependabot gitsubmodule updates.

https://datadoghq.atlassian.net/wiki/spaces/PANA/pages/6713639211/FFE+SDK+Fixture+Contribution+Guide

github-actions · 2026-05-12T16:44:53Z

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

Base Branch: origin/main
PR Branch: origin/leo.romanovsky/ffe-canonical-fixtures-20260512

Summary by Rule

Rule	Base Branch	PR Branch	Change

Annotation Counts by File

File	Base Branch	PR Branch	Change

Annotation Stats by Crate

Crate	Base Branch	PR Branch	Change
`clippy-annotation-reporter`	5	5	No change (0%)
`datadog-ffe-ffi`	1	1	No change (0%)
`datadog-ipc`	21	21	No change (0%)
`datadog-live-debugger`	6	6	No change (0%)
`datadog-live-debugger-ffi`	10	10	No change (0%)
`datadog-profiling-replayer`	4	4	No change (0%)
`datadog-remote-config`	3	3	No change (0%)
`datadog-sidecar`	57	57	No change (0%)
`libdd-common`	13	13	No change (0%)
`libdd-common-ffi`	12	12	No change (0%)
`libdd-data-pipeline`	5	5	No change (0%)
`libdd-ddsketch`	2	2	No change (0%)
`libdd-dogstatsd-client`	1	1	No change (0%)
`libdd-profiling`	13	13	No change (0%)
`libdd-telemetry`	20	20	No change (0%)
`libdd-tinybytes`	4	4	No change (0%)
`libdd-trace-normalization`	2	2	No change (0%)
`libdd-trace-obfuscation`	8	8	No change (0%)
`libdd-trace-stats`	1	1	No change (0%)
`libdd-trace-utils`	15	15	No change (0%)
Total	203	203	No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

datadog-prod-us1-3 · 2026-05-12T17:10:59Z

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 72.67% (+0.09%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: dcf589d | Docs | Datadog PR Page | Give us feedback!}

codecov-commenter · 2026-05-13T02:52:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.67%. Comparing base (866d7c8) to head (dcf589d).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
+ Coverage   72.58%   72.67%   +0.08%     
==========================================
  Files         451      452       +1     
  Lines       74095    74845     +750     
==========================================
+ Hits        53782    54393     +611     
- Misses      20313    20452     +139

Components	Coverage Δ
libdd-crashtracker	`65.31% <ø> (ø)`
libdd-crashtracker-ffi	`37.56% <ø> (-0.13%)`	⬇️
libdd-alloc	`98.77% <ø> (ø)`
libdd-data-pipeline	`86.00% <ø> (+0.03%)`	⬆️
libdd-data-pipeline-ffi	`71.04% <ø> (ø)`
libdd-common	`79.81% <ø> (ø)`
libdd-common-ffi	`74.41% <ø> (ø)`
libdd-telemetry	`73.34% <ø> (+3.45%)`	⬆️
libdd-telemetry-ffi	`31.36% <ø> (+11.99%)`	⬆️
libdd-dogstatsd-client	`82.64% <ø> (ø)`
datadog-ipc	`76.22% <ø> (ø)`
libdd-profiling	`81.59% <ø> (+0.01%)`	⬆️
libdd-profiling-ffi	`64.51% <ø> (ø)`
libdd-sampling	`97.46% <ø> (+0.21%)`	⬆️
datadog-sidecar	`28.97% <ø> (-0.16%)`	⬇️
datdog-sidecar-ffi	`9.08% <ø> (-0.60%)`	⬇️
spawn-worker	`48.86% <ø> (-5.83%)`	⬇️
libdd-tinybytes	`93.16% <ø> (ø)`
libdd-trace-normalization	`81.71% <ø> (ø)`
libdd-trace-obfuscation	`87.39% <ø> (ø)`
libdd-trace-protobuf	`68.25% <ø> (ø)`
libdd-trace-utils	`89.59% <ø> (+0.73%)`	⬆️
libdd-tracer-flare	`86.88% <ø> (ø)`
libdd-log	`74.83% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dd-octo-sts · 2026-05-13T03:14:33Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	7.57 MB	7.57 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	81.84 MB	81.84 MB	0% (0 B) 👌

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	98.03 MB	98.03 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.01 MB	10.01 MB	0% (0 B) 👌

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	24.48 MB	24.48 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	79.87 KB	79.87 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	180.22 MB	180.23 MB	+0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	913.92 MB	913.92 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	7.73 MB	7.73 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	79.87 KB	79.87 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	23.17 MB	23.17 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	45.36 MB	45.36 MB	0% (0 B) 👌

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	21.09 MB	21.09 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	81.11 KB	81.11 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	184.40 MB	184.40 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	900.39 MB	900.39 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	5.99 MB	5.99 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	81.11 KB	81.11 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	24.80 MB	24.80 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	42.86 MB	42.86 MB	0% (0 B) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	72.93 MB	72.93 MB	0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	8.42 MB	8.42 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	90.69 MB	90.69 MB	0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	10.06 MB	10.06 MB	0% (0 B) 👌

sameerank

It might help to include instructions like this for folks who may not be familiar

If this is a fresh clone, initialize submodules first:
git submodule update --init --recursive

perhaps in this section?

libdatadog/README.md

Lines 27 to 30 in 6e559d7

    
           ### Building 
        
           Build `libdatadog` as usual with `cargo build`.

hoolioh

LGTM, thank you for doing the changes.

Use canonical FFE fixtures

99892b0

github-actions Bot added the ci-build label May 12, 2026

Update FFE fixture submodule

9faafd3

leoromanovsky changed the title ~~Use canonical FFE fixtures~~ test(ffe): use canonical fixtures May 13, 2026

Fix canonical FFE fixture CI paths

393938a

Resolve FFE fixture paths from package root

2c1a5e0

leoromanovsky commented May 13, 2026

View reviewed changes

Comment thread datadog-ffe/src/rules_based/eval/eval_assignment.rs Outdated

leoromanovsky added 3 commits May 13, 2026 11:17

test(ffe): stop asserting fixture reasons

247a5e0

test(ffe): update fixtures submodule to main

ef516b4

ci(benchmarks): initialize submodules

4aefcc6

leoromanovsky marked this pull request as ready for review May 13, 2026 17:25

leoromanovsky requested review from a team as code owners May 13, 2026 17:25

leoromanovsky requested review from dd-oleksii, greghuels and sameerank and removed request for a team and greghuels May 13, 2026 17:25

sameerank approved these changes May 13, 2026

View reviewed changes

hoolioh requested changes May 14, 2026

View reviewed changes

Comment thread datadog-ffe-test-suite/ffe-system-test-data

test(ffe): isolate canonical fixture suite

dcf589d

leoromanovsky requested a review from hoolioh May 15, 2026 18:19

hoolioh approved these changes May 18, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting and removed mergequeue-status: waiting labels May 18, 2026

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels May 18, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 47e0f4e into main May 18, 2026
120 of 122 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label May 18, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the leo.romanovsky/ffe-canonical-fixtures-20260512 branch May 18, 2026 13:27

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label May 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(ffe): use canonical fixtures#1979

test(ffe): use canonical fixtures#1979
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits into
mainfrom
leo.romanovsky/ffe-canonical-fixtures-20260512

leoromanovsky commented May 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

datadog-prod-us1-3 Bot commented May 12, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

Uh oh!

codecov-commenter commented May 13, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented May 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

sameerank left a comment

Uh oh!

Uh oh!

hoolioh left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

leoromanovsky commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes and Decisions

Uh oh!

github-actions Bot commented May 12, 2026

Clippy Allow Annotation Report

Summary by Rule

Annotation Counts by File

Annotation Stats by Crate

About This Report

Uh oh!

datadog-prod-us1-3 Bot commented May 12, 2026 • edited by datadog-datadog-prod-us1-2 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dd-octo-sts Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

Uh oh!

sameerank left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hoolioh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leoromanovsky commented May 12, 2026 •

edited

Loading

datadog-prod-us1-3 Bot commented May 12, 2026 •

edited by datadog-datadog-prod-us1-2 Bot

Loading

codecov-commenter commented May 13, 2026 •

edited

Loading

dd-octo-sts Bot commented May 13, 2026 •

edited

Loading