perf(profiling): observation map doesn't need HashDos protection#1988
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intoMay 15, 2026
Merged
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 58e90ad | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1988 +/- ##
=======================================
Coverage 72.69% 72.70%
=======================================
Files 452 452
Lines 74893 74893
=======================================
+ Hits 54446 54449 +3
+ Misses 20447 20444 -3
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
gleocadie
approved these changes
May 15, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit d33f94d: What to do next?
|
Contributor
Author
Retrying merge. |
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit d49a56c: What to do next?
|
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
May 15, 2026
… disk space (#2001) # What does this PR do? Since #1928 we've been intermittently running out of disk space on our GH runners for tests. This PR bumps the size of our ubuntu runners, which includes more disk space and should solve this issue. # Motivation @morrisonlevi was seeing consistent failures on the MQ when running the full test suite on this PR: #1988 # Additional Notes Anything else we should know when reviewing? # How to test the change? Describe here in detail how the change can be validated. Co-authored-by: edmund.kump <edmund.kump@datadoghq.com>
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
and removed
mergequeue-status: rejected
mergequeue-status: queued
labels
danielsn
approved these changes
May 15, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: rejected
and removed
mergequeue-status: in_progress
labels
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
levi/AggregatedObservations-fxhash
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes
AggregatedObservations'sHashMapto useFxHasherfor its hasher instead of the default.Motivation
HashDos protection comes built-in with the default hasher type, and it's unnecessary here. It's more performant in general to use
FxHasher.Additional Notes
My motivation here isn't actually performance, although it's true; I want a deterministic hasher between runs so iteration order is preserved. I am trying to make another version of the
ddog_prof_Profile_serializefunction. I want bit-for-bit fuzz accuracy for property testing it, but with a HashDos protected HashMap, the order of iteration will change from map to map.But even if this other work doesn't land, it's true we're paying for HashDos protection that we don't need, which is why I opened this as its own PR.
How to test the change?
Test as regularly done--this shouldn't change anything.