feat(trace-utils)!: add dedup convenience to VecMap#2049
Open
yannham wants to merge 3 commits into
Open
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
🔒 Cargo Deny Results📦
|
|
Comment on lines
+221
to
+222
| static WARNED: AtomicBool = AtomicBool::new(false); | ||
| if !WARNED.swap(true, Ordering::Relaxed) { |
Contributor
There was a problem hiding this comment.
Since the condition is unlikely, wouldn't it be better to do a relaxed atomic load, and a conditional store? (of course, we might get duplicata if used concurrently but I don't think it's that likely or we will get that many if ti happens)
Contributor
Author
There was a problem hiding this comment.
Well, this is the same discussion we had for the dedup flag, and it seems the wisdom is it's actually faster to unconditionally store (store buffer, avoided conditional even if predicted, yadayada). I think the case where it's not true is when the variable is contended (storing needs an exclusive cache line, which might invalidate the cache of other cores, while loading doesn't). But if we don't expect this to actually be accessed concurrently, the situation should be rather similar to deduped (we just have to use atomics to please the compiler)...
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
+ Coverage 72.90% 72.92% +0.02%
==========================================
Files 460 460
Lines 76396 76481 +85
==========================================
+ Hits 55696 55774 +78
- Misses 20700 20707 +7
🚀 New features to boost your workflow:
|
yannham
changed the title
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Comment on lines
+202
to
+203
| .into_iter() | ||
| .collect(), |
Contributor
There was a problem hiding this comment.
Why the 2nd collect to VecMap here?
Wouldn't it be the exact same, with one less copy for the Owned variant to beDedupedVecMap::Owned(HashMap<K, V>)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up of #2022. This split off some work required in #2043 for deduplication before msgpack encoding as a separate PR.
Motivation
See #2022 for overall motivation. To integrate
VecMap, it turns out we can't currently rely on the agent to properly handle maps with deuplicate entries (the "last win" semantics is the current implementation, but not guaranteed). We need to perform deduplication before msgpack encoding. This PR backports the required machinery intoVecMapas a separate PR.Additional Notes
N/A
How to test the change?
Tests included.