fix(sampling): disable libdd-common default features#2057
Merged
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
bantonsson
approved these changes
May 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
- Coverage 72.93% 72.93% -0.01%
==========================================
Files 460 460
Lines 76430 76430
==========================================
- Hits 55745 55742 -3
- Misses 20685 20688 +3
🚀 New features to boost your workflow:
|
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c148bd9 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This was referenced May 29, 2026
iunanua
added a commit
that referenced
this pull request
May 29, 2026
# Release proposal for libdd-sampling and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-common **Next version:** `4.2.0` **Semver bump:** `minor` **Tag:** `libdd-common-v4.2.0` ### Commits - refactor(trace-utils): replace use_v05_format bool and remove infallible expect (#1946) - feat(libdd-common): recognize PCF Garden container IDs (#2025) ## libdd-trace-utils (bumped manually due to breaking in #1946) **Next version:** ~~`5.1.0`~~ `6.0.0` **Semver bump:** ~~`minor`~~ `major` **Tag:** ~~`libdd-trace-utils-v5.1.0`~~ `libdd-trace-utils-v6.0.0` ### Commits - feat(trace-utils)!: introduce VecMap datastructure (#2022) - feat: update test agent version (#2038) - refactor(trace-utils): replace use_v05_format bool and remove infallible expect (#1946) The breaking change is the signature of the public function `libdd_trace_utils::trace_utils::collect_trace_chunks`: - Before: `pub fn collect_trace_chunks<T: TraceData>(traces: ..., use_v05_format: bool)` -> ... - After: `pub fn collect_trace_chunks<T: TraceData>(traces: ..., format: TraceEncoding)` -> ... ## libdd-sampling **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-sampling-v2.0.0` ### :warning: major bump forced due to: - `libdd-trace-utils`: ^4.0.0 → ^6.0.0 ### Commits - fix(sampling): disable libdd-common default features (#2057) - feat(trace-utils)!: add from_string to span text (#2011) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: iunanua <18325288+iunanua@users.noreply.github.com> Co-authored-by: iunanua <igor.unanua@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set
default-features = falseflag forlibdd-commondepMotivation
libdd-common's defaults includehttps, which expands torustls+hyper-rustls+tokio-rustls+rustls-native-certs+ring.So
libdd-sampling's dep declaration silently pulls the whole TLS stack into every build.