refactor(clippy): prefer core and alloc imports#2196
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intoJul 6, 2026
Merged
refactor(clippy): prefer core and alloc imports#2196gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
Conversation
…ippy-converts-to-core-and-alloc
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 7b03d28 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
There was a problem hiding this comment.
Pull request overview
Enables Clippy’s std_instead_of_alloc / std_instead_of_core lints and applies the resulting mechanical rewrites to prefer core/alloc paths where available, supporting the workspace’s no-std compatibility efforts.
Changes:
- Enabled
clippy::std_instead_of_allocandclippy::std_instead_of_coreat the workspace level and for selected crates. - Rewrote imports and fully-qualified paths from
std::...tocore::.../alloc::...where equivalents exist. - Added
extern crate alloc;in crates/targets that now referencealloc.
Reviewed changes
Copilot reviewed 77 out of 77 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Enables workspace-level Clippy lints for preferring core/alloc over std. |
| libdd-trace-obfuscation/src/lib.rs | Adds extern crate alloc; to support alloc::... usage in the crate. |
| libdd-trace-obfuscation/src/obfuscation_config.rs | Switches error trait object from std::error::Error to core::error::Error. |
| libdd-trace-obfuscation/src/replacer.rs | Uses core::mem::swap instead of std::mem::swap. |
| libdd-trace-obfuscation/src/sql.rs | Uses core::fmt::Write in tests. |
| libdd-trace-obfuscation/src/json/mod.rs | Switches ToString path to alloc::string::ToString in tests. |
| libdd-trace-obfuscation/src/ip_address.rs | Moves Cow/Ipv6Addr imports to alloc/core where available. |
| libdd-trace-obfuscation/src/http.rs | Uses core::fmt::Write instead of std::fmt::Write. |
| libdd-trace-obfuscation/tests/test_span_obfuscation.rs | Updates test imports/formatting traits to prefer alloc/core and adds extern crate alloc;. |
| libdd-trace-obfuscation/benches/trace_obfuscation.rs | Adds extern crate alloc; for bench targets using alloc. |
| libdd-trace-obfuscation/benches/benchmarks/ip_address_bench.rs | Uses alloc::borrow::Cow in benches. |
| libdd-trace-obfuscation/benches/benchmarks/credit_cards_bench.rs | Switches black_box/Duration to core equivalents. |
| libdd-library-config/Cargo.toml | Enables crate-level Clippy lints for preferring core/alloc. |
| libdd-library-config/src/lib.rs | Adds extern crate alloc; and adjusts common imports to alloc/core. |
| libdd-library-config/src/tracer_metadata.rs | Uses core paths for Default/iter::once. |
| libdd-library-config/src/otel_process_ctx.rs | Splits imports: core for common primitives, std for OS/FD and sync types; uses core::mem::swap etc. |
| libdd-library-config-ffi/Cargo.toml | Enables crate-level Clippy lints for preferring core/alloc. |
| libdd-library-config-ffi/src/lib.rs | Adds extern crate alloc;, uses core::panic::AssertUnwindSafe, and switches to alloc::ffi/core::ffi where applicable. |
| libdd-library-config-ffi/src/tracer_metadata.rs | Uses core::ffi::CStr instead of std::ffi::CStr. |
| libdd-crashtracker/Cargo.toml | Enables crate-level Clippy lints for preferring core/alloc. |
| libdd-crashtracker/src/lib.rs | Adds extern crate alloc; to support alloc::... usage in the crate. |
| libdd-crashtracker/src/receiver/mod.rs | Adds file-level allow for std_instead_of_{alloc,core} where std is required. |
| libdd-crashtracker/src/shared/constants.rs | Uses core::time::Duration. |
| libdd-crashtracker/src/shared/configuration/mod.rs | Uses core::time::Duration. |
| libdd-crashtracker/src/shared/configuration/builder.rs | Switches Cow/Duration to alloc/core, including tests. |
| libdd-crashtracker/src/runtime_callback.rs | Uses core::ffi/core::ptr/core::mem where available; uses alloc::ffi::CString in tests. |
| libdd-crashtracker/src/crash_info/telemetry.rs | Uses core::fmt::Write and core::time::Duration where possible. |
| libdd-crashtracker/src/crash_info/stacktrace.rs | Uses core::fmt::Write. |
| libdd-crashtracker/src/crash_info/errors_intake.rs | Moves Cow/Duration to alloc/core and trims std imports accordingly. |
| libdd-crashtracker/src/crash_info/error_data.rs | Switches Rc import to alloc::rc::Rc under cfg(unix). |
| libdd-crashtracker/src/common.rs | Uses alloc::ffi::CString. |
| libdd-crashtracker/src/collector/spans.rs | Moves NonZeroU128 import to core. |
| libdd-crashtracker/src/collector/signal_handler_manager.rs | Moves ptr/atomics and cmp::max usage to core. |
| libdd-crashtracker/src/collector/saguard.rs | Uses core::sync::atomic in tests. |
| libdd-crashtracker/src/collector/receiver_manager.rs | Moves ptr/atomics and mem::drop usage to core. |
| libdd-crashtracker/src/collector/emitters.rs | Uses core::{mem,ptr,ffi} where available and adjusts test imports accordingly. |
| libdd-crashtracker/src/collector/crash_handler.rs | Moves ptr/atomics and mem helpers to core. |
| libdd-crashtracker/src/collector/counters.rs | Uses core::sync::atomic. |
| libdd-crashtracker/src/collector/atomic_set.rs | Moves common traits/types (cmp/ptr/atomics) to core and BTreeMap to alloc in tests. |
| libdd-crashtracker/src/collector/api.rs | Uses core::mem::transmute, core::ptr::null{,_mut}, and core::time::Duration in tests. |
| libdd-crashtracker/src/collector_windows/api.rs | Switches many foundational utilities (slice, str, ptr, c_void, MaybeUninit) to core. |
| libdd-crashtracker/benches/receiver_bench.rs | Adds allow for std_instead_of_{alloc,core} and consolidates imports. |
| libdd-common/Cargo.toml | Enables crate-level Clippy lints for preferring core/alloc. |
| libdd-common/src/lib.rs | Adds extern crate alloc; and moves Cow/Deref/FromStr to alloc/core as applicable. |
| libdd-common/src/http_common.rs | Uses core for Infallible, fmt signatures, Error trait, tasks, and pinning types. |
| libdd-common/src/error.rs | Switches CStr and UTF-8 conversion to core. |
| libdd-common/src/tag.rs | Moves Cow/fmt traits and fmt::Result to alloc/core. |
| libdd-common/src/rate_limiter.rs | Uses core::sync::atomic and updates test import accordingly. |
| libdd-common/src/timeout.rs | Uses core::time::Duration while retaining std::time::Instant. |
| libdd-common/src/test_utils.rs | Uses core::ops::Deref, core::mem in Windows block, and alloc::sync::Arc in tests. |
| libdd-common/src/unix_utils/process.rs | Uses core::time::Duration in tests. |
| libdd-common/src/unix_utils/fork.rs | Uses core::{str::from_utf8, ptr::null_mut} where applicable. |
| libdd-common/src/unix_utils/execve.rs | Moves CString/NulError to alloc::ffi and related helpers to core. |
| libdd-common/src/config.rs | Moves FromStr/Duration to core, keeps std::env. |
| libdd-common/src/bench_utils.rs | Moves GlobalAlloc/Layout/atomics to core, keeps System in std. |
| libdd-common/src/connector/mod.rs | Uses core::{future::Future,pin::Pin,task::{Context,Poll}}. |
| libdd-common/src/connector/errors.rs | Uses alloc::fmt instead of std::fmt. |
| libdd-common/src/connector/conn_stream.rs | Uses core for Pin/task types and updates trait object error bound to core::error::Error. |
| libdd-common/src/entity_id/unix/mod.rs | Uses alloc::fmt and core::ops::Deref::deref where applicable. |
| libdd-common/src/dump_server.rs | Uses core::str::from_utf8 for header parsing. |
| libdd-common/src/cstr.rs | Switches CStr::from_bytes_with_nul_unchecked to core::ffi::CStr. |
| libdd-common/src/machine_id/windows.rs | Uses core::iter::once and core::ptr::null_mut. |
| libdd-common/src/azure_app_services.rs | Uses core::str::from_utf8 for parsing environment entries. |
| libdd-common-ffi/Cargo.toml | Enables crate-level Clippy lints for preferring core/alloc. |
| libdd-common-ffi/src/lib.rs | Adds extern crate alloc; for alloc::... usage across the crate. |
| libdd-common-ffi/src/vec.rs | Uses core for PhantomData, ManuallyDrop, NonNull, and switches internal vec type to alloc::vec::Vec. |
| libdd-common-ffi/src/utils.rs | Uses core::panic::AssertUnwindSafe and core::any::Any, adjusts macro imports accordingly. |
| libdd-common-ffi/src/timespec.rs | Uses core::fmt::Debug. |
| libdd-common-ffi/src/string.rs | Uses core::mem::take. |
| libdd-common-ffi/src/slice.rs | Moves many foundational imports (fmt, hashing, c_char, Utf8Error) to core/alloc, updates fmt::Result usage. |
| libdd-common-ffi/src/slice_mut.rs | Moves fmt, hashing, NonNull to core, updates fmt::Result usage. |
| libdd-common-ffi/src/option.rs | Uses core::fmt::Debug and core::option::Option in conversion helpers. |
| libdd-common-ffi/src/handle.rs | Uses core::ptr::null_mut and core::mem::replace. |
| libdd-common-ffi/src/error.rs | Switches formatting and error trait impls to core, uses core::mem::swap, and updates trait-object conversion bound. |
| libdd-common-ffi/src/endpoint.rs | Moves Cow/FromStr to alloc/core. |
| libdd-common-ffi/src/cstr.rs | Moves many std paths to core/alloc (CString, NulError, CStr, slice), keeping semantics intact. |
| libdd-common-ffi/src/array_queue.rs | Uses core::{ffi::c_void, ptr::NonNull}, and moves atomics/mem/ptr helpers in tests to core. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yannham
approved these changes
Jul 6, 2026
yannham
left a comment
yannham
left a comment
Contributor
There was a problem hiding this comment.
Looks benign and scoped 👍
paullegranddc
approved these changes
Jul 6, 2026
Comment on lines
+4
to
+6
| use alloc::ffi::{CString as AllocCString, NulError}; | ||
| use alloc::vec::Vec; | ||
| use core::ffi::CStr as CoreCStr; |
Contributor
There was a problem hiding this comment.
Why the type aliasing here?
Contributor
Author
There was a problem hiding this comment.
initially it was to avoid clashes. but that is not really needed, so I now dropped it
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
Contributor
Author
|
Thanks @yannham and @paullegranddc for the review! 🙇 |
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
refactor/clippy-core-alloc-imports
branch
iunanua
added a commit
that referenced
this pull request
Jul 7, 2026
…ibdd-data-pipeline, libdd-li... (#2201) # Release proposal for libdd-capabilities-impl, libdd-common, libdd-data-pipeline, libdd-library-config, libdd-remote-config, libdd-sampling, libdd-telemetry, libdd-tinybytes, libdd-trace-utils and their dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-capabilities **Next version:** `2.1.0` **Semver bump:** `minor` **Tag:** `libdd-capabilities-v2.1.0` ### Commits - feat(data-pipeline)!: add stdout log trace exporter (#2074) ## libdd-common **Next version:** `5.1.0` **Semver bump:** `minor` **Tag:** `libdd-common-v5.1.0` ### Commits - refactor(clippy): prefer core and alloc imports (#2196) - fix: update rustls-webpki to 0.103.13 (#2187) - fix: update anyhow for unsoundness (#2186) - feat(machine id): Add helpers in ddcommon to fetch the machine UUID l… (#2163) ## libdd-ddsketch **Next version:** `1.1.0` **Semver bump:** `minor` **Tag:** `libdd-ddsketch-v1.1.0` ### Commits - feat(data-pipeline)!: export client-computed span stats as OTLP trace metrics (#2067) - test(ddsketch): add microbenchmarks for add/encode/collapse (#2125) ## libdd-trace-protobuf **Next version:** `4.0.0` **Semver bump:** `major` **Tag:** `libdd-trace-protobuf-v4.0.0` ### Commits - chore!: update protobufs to be in sync with datadog-agent (#2180) - feat(stats)!: add whole key cardinality limit (#2158) - feat(remote-config)!: use the proto file from the agent (#2165) - feat(data-pipeline): OTLP HTTP/protobuf trace export (#2115) ## libdd-capabilities-impl **Next version:** `3.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-impl-v3.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.1.0 → ^5.1.0 ### Commits - feat(data-pipeline)!: add stdout log trace exporter (#2074) ## libdd-library-config **Next version:** `3.0.0` **Semver bump:** `major` **Tag:** `libdd-library-config-v3.0.0` ###⚠️ major bump forced due to: - `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0 ### Commits - refactor(clippy): prefer core and alloc imports (#2196) - feat(library-config)!: caller-supplied threadlocal schema and extra process-context attributes (#2162) - fix(otel-thread-ctx): put the threadlocal attributes at the right place in the context (#2167) ## libdd-remote-config **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-remote-config-v2.0.0` ###⚠️ major bump forced due to: - `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0 ### Commits - refactor(libdd-remote-config)!: hide Target inner properties so they are not leaked (#2182) - feat(remote-config)!: use the proto file from the agent (#2165) - refactor(rc): reexport Endpoint and Tag common types (#2147) ## libdd-trace-normalization **Next version:** `3.0.0` **Semver bump:** `major` **Tag:** `libdd-trace-normalization-v3.0.0` ###⚠️ major bump forced due to: - `libdd-trace-protobuf`: ^3.0.1 → ^4.0.0 ### Commits - feat(data-pipeline)!: CSS Trace Filters (#1985) ## libdd-shared-runtime **Next version:** `2.0.0` **Semver bump:** `major` **Tag:** `libdd-shared-runtime-v2.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.1.0 → ^5.1.0 ### Commits - feat(shared-runtime)!: SharedRuntime Borrowed & Owned mode (#2061) - feat(shared-runtime)!: use weak waker in trigger [APMSP-3371] (#2050) ## libdd-trace-utils **Next version:** `9.0.0` **Semver bump:** `major` **Tag:** `libdd-trace-utils-v9.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.2.0 → ^5.1.0 - `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0 ### Commits - ci(miri): skip slow miri tests (#2188) - chore!: update protobufs to be in sync with datadog-agent (#2180) - feat(data-pipeline): add agentless export (#2081) - feat(data-pipeline)!: add stdout log trace exporter (#2074) - feat(data-pipeline): OTLP HTTP/protobuf trace export (#2115) - feat(otlp)!: Export OTLP spans with attribute-level OTel compatibility (#2091) - test(trace-utils): add V05 msgpack decode microbenchmark (#2127) - feat(data-pipeline)!: export client-computed span stats as OTLP trace metrics (#2067) - test(trace-utils): add VecMap microbenchmarks (#2126) - chore(stats)!: submit p0 telemetry in stats (#2130) - refactor(change-buffer)!: replace slot index with span_id, fix segment isolation (#2105) - feat(data-pipeline)!: CSS Trace Filters (#1985) - feat(trace-exporter): add v1 span and its encoder (#2039) - fix(trace-utils): mark decoded span maps as deduped (#2110) - feat(trace-utils)!: change buffer implementation (#2055) - feat(native-spans)!: change buffer foundation (#2046) - refactor(span)!: use VecMap for `meta`, `metrics` and `meta_struct` for v04 spans (#2043) - test: fix timeouts on heavily contended scenarios (#2093) ## libdd-telemetry **Next version:** `6.0.0` **Semver bump:** `major` **Tag:** `libdd-telemetry-v6.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.2.0 → ^5.1.0 - `libdd-shared-runtime`: ^1.0.0 → ^2.0.0 ### Commits - ci(miri): skip slow miri tests (#2188) - refactor(libdd-telemetry)!: avoid leaking libdd-common types in the public API (#2152) - feat(shared-runtime)!: SharedRuntime Borrowed & Owned mode (#2061) ## libdd-trace-obfuscation **Next version:** `5.0.0` **Semver bump:** `major` **Tag:** `libdd-trace-obfuscation-v5.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.2.0 → ^5.1.0 - `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0 - `libdd-trace-utils`: ^8.0.0 → ^9.0.0 ### Commits - refactor(clippy): prefer core and alloc imports (#2196) - ci(miri): skip slow miri tests (#2188) - fix: update anyhow for unsoundness (#2186) ## libdd-trace-stats **Next version:** `6.0.0` **Semver bump:** `major` **Tag:** `libdd-trace-stats-v6.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.2.0 → ^5.1.0 - `libdd-shared-runtime`: ^1.0.0 → ^2.0.0 - `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0 - `libdd-trace-utils`: ^8.0.0 → ^9.0.0 ### Commits - chore!: update protobufs to be in sync with datadog-agent (#2180) - feat(stats)!: send telemetry for cardinality limits (#2159) - feat(stats)!: add whole key cardinality limit (#2158) - fix(trace-stats)!: add grpc_method to aggregation key (#2151) - feat(shared-runtime)!: SharedRuntime Borrowed & Owned mode (#2061) - feat(data-pipeline)!: export client-computed span stats as OTLP trace metrics (#2067) - refactor(span)!: use VecMap for `meta`, `metrics` and `meta_struct` for v04 spans (#2043) ## libdd-data-pipeline **Next version:** `7.0.0` **Semver bump:** `major` **Tag:** `libdd-data-pipeline-v7.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.2.0 → ^5.1.0 - `libdd-shared-runtime`: ^1.0.0 → ^2.0.0 - `libdd-telemetry`: ^5.0.1 → ^6.0.0 - `libdd-trace-protobuf`: ^3.0.2 → ^4.0.0 - `libdd-trace-stats`: ^5.0.0 → ^6.0.0 - `libdd-trace-utils`: ^8.0.0 → ^9.0.0 ### Commits - feat(trace_exporter): enable telemetry in stats exporter (#2160) - refactor(libdd-telemetry)!: avoid leaking libdd-common types in the public API (#2152) - feat(stats): emit canonical gRPC status name for OTLP rpc.response.status_code (#2183) - feat(data-pipeline): add agentless export (#2081) - feat(stats)!: send telemetry for cardinality limits (#2159) - feat(stats)!: add whole key cardinality limit (#2158) - fix(trace-stats)!: add grpc_method to aggregation key (#2151) - feat(data-pipeline)!: add stdout log trace exporter (#2074) - feat(shared-runtime)!: SharedRuntime Borrowed & Owned mode (#2061) - feat(data-pipeline): OTLP HTTP/protobuf trace export (#2115) - feat(otlp)!: Export OTLP spans with attribute-level OTel compatibility (#2091) - feat(data-pipeline)!: export client-computed span stats as OTLP trace metrics (#2067) - chore(stats)!: submit p0 telemetry in stats (#2130) - feat(data-pipeline)!: CSS Trace Filters (#1985) - feat(shared-runtime)!: use weak waker in trigger [APMSP-3371] (#2050) - refactor(span)!: use VecMap for `meta`, `metrics` and `meta_struct` for v04 spans (#2043) - feat(stats)!: add endpoint gating to client-side stats [APMSP-3361] (#2040) ## libdd-dogstatsd-client **Next version:** `4.0.0` **Semver bump:** `major` **Tag:** `libdd-dogstatsd-client-v4.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.1.0 → ^5.1.0 ## libdd-sampling **Next version:** `5.0.0` **Semver bump:** `major` **Tag:** `libdd-sampling-v5.0.0` ###⚠️ major bump forced due to: - `libdd-common`: ^4.2.0 → ^5.1.0 - `libdd-trace-utils`: ^8.0.0 → ^9.0.0 [APMSP-3371]: https://datadoghq.atlassian.net/browse/APMSP-3371?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: iunanua <18325288+iunanua@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Enabled
clippy::std_instead_of_allocandclippy::std_instead_of_corefor the targeted crates and the workspace-inheritinglibdd-trace-obfuscationcrate.Applied the resulting mechanical imports and path rewrites from
stdtocoreorallocwhere available.Merged the latest
origin/maininto this branch and renamed the branch torefactor/clippy-core-alloc-imports.Why
This narrows standard-library dependencies where the APIs are available from
coreoralloc, supporting the repository no-std compatibility work.Validation
cargo +nightly-2026-02-08 fmt --all -- --checkcargo +stable clippy --workspace --all-targets --all-features -- -D warningsReplacement for closed PR #2116.