Fix or work around clippy lints #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing allow(clippy::get_first) or any other lint that doesn't exist on 1.60 is annoying.
r1viollet
approved these changes
Jul 9, 2022
Contributor
r1viollet
left a comment
r1viollet
left a comment
There was a problem hiding this comment.
LGTM
Thanks for taking care of these
paullegranddc
approved these changes
Jul 9, 2022
ivoanjo
added a commit
that referenced
this pull request
Jun 18, 2025
Currently, Java uses microsecond precision for uploaded profile start/end, whereas Ruby, Python, Go and libddprof use second precision. While discussing with @flodav he made a good point that just truncating the start and end would mean that we could induce quite a bit of error. I decided to bump it to nanos, since we have it anyway. Open to change, if it's overkill :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes or works around clippy lints that exist on nightly.
Motivation
I didn't like having a broken CI job as well as a broken clippy checker if I ran it locally.
Additional Notes
Nightly is annoying but helpful.
How to test the change?
Regular tests should work.