Skip to content

[crashtracker] Remove debug print statement#533

Merged
danielsn merged 1 commit into
mainfrom
dsn/crashtracker-remove-eprintln
Jul 16, 2024
Merged

[crashtracker] Remove debug print statement#533
danielsn merged 1 commit into
mainfrom
dsn/crashtracker-remove-eprintln

Conversation

@danielsn
Copy link
Copy Markdown
Contributor

@danielsn danielsn commented Jul 16, 2024

What does this PR do?

What it says on the tin.

Motivation

Left a debug statement in by accident.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested a review from a team as a code owner July 16, 2024 19:36
Copy link
Copy Markdown
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (bfeef6d) to head (cb7ff4f).
Report is 171 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   70.29%   70.29%           
=======================================
  Files         206      206           
  Lines       27819    27818    -1     
=======================================
  Hits        19554    19554           
+ Misses       8265     8264    -1     
Components Coverage Δ
crashtracker 16.87% <ø> (+0.01%) ⬆️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 51.15% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.41% <ø> (ø)
ddcommon-ffi 75.31% <ø> (ø)
ddtelemetry 59.02% <ø> (ø)
ipc 84.13% <ø> (ø)
profiling 78.68% <ø> (ø)
profiling-ffi 58.26% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 35.64% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 70.93% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 90.68% <ø> (ø)

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jul 16, 2024

Benchmarks

This comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output.

@danielsn danielsn merged commit 63d4ec8 into main Jul 16, 2024
@danielsn danielsn deleted the dsn/crashtracker-remove-eprintln branch July 16, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants