[Crashtracker] Track active spans and traces#536
Merged
Conversation
BenchmarksThis comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output. |
Contributor
Library Vulnerabilities✅ No library vulnerabilities found (scanned 519f61c). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
==========================================
- Coverage 70.63% 70.50% -0.14%
==========================================
Files 206 208 +2
Lines 28112 28397 +285
==========================================
+ Hits 19856 20020 +164
- Misses 8256 8377 +121
|
taegyunkim
approved these changes
Jul 18, 2024
Comment on lines
+9
to
+10
| static ACTIVE_SPANS: AtomicU128Set<2048> = AtomicU128Set::new(); | ||
| static ACTIVE_TRACES: AtomicU128Set<2048> = AtomicU128Set::new(); |
Contributor
There was a problem hiding this comment.
Where did 2048 come from?
sanchda
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides a mechanism for clients to record active spans/traces, and reports them in the crashreport.
Motivation
Error-tracking said this would be useful to help corrlate crashes with the traces they affected.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.