Add document describing the new build process.#579
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 71.77% 71.69% -0.08%
==========================================
Files 238 238
Lines 32924 32941 +17
==========================================
- Hits 23631 23617 -14
- Misses 9293 9324 +31
|
BenchmarksComparisonBenchmark execution time: 2024-08-22 12:33:17 Comparing candidate commit c4e05fe in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics. scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |
hoolioh
force-pushed
the
julio/build-process-proposal
branch
2 times, most recently
from
ef9eade to
72ac5bc
Compare
pawelchcki
reviewed
Aug 6, 2024
danielsn
reviewed
Aug 8, 2024
danielsn
reviewed
Aug 8, 2024
hoolioh
force-pushed
the
julio/build-process-proposal
branch
from
e2db271 to
81f3db5
Compare
pawelchcki
approved these changes
Aug 22, 2024
Contributor
|
LGTM! |
gleocadie
reviewed
Aug 22, 2024
Comment on lines
+4
to
+10
| As described in the [RFC](https://github.com/DataDog/libdatadog/blob/main/docs/RFCs/0001-delivering-different-features.md) | ||
| about delivering different features the current build process depends heavily on shell scripts which makes it too | ||
| difficult in terms of managning the process itself like handling errors, dependendencies and features. Also shell | ||
| scripts by themselves poses some disadvantages like portability and maintanibilty. | ||
|
|
||
| This solution aims to get rid of those problems so the whole procedure depends as much as possible of built-in features | ||
| of cargo making it less error prone and also improving its maintanibilty. |
Contributor
There was a problem hiding this comment.
Agree🤔
I would say that shell script allows to have the same command everywhere instead of searching for the command in the yaml file.
Do not get me wrong, I'm not against just saying that they are useful (in some case).
Now, I see that we can build, generate bindings in one-line command thanks for that🙇♂️
Contributor
There was a problem hiding this comment.
Now, I see that we can build, generate bindings
^-------------------------- am I correct ?
Contributor
Author
There was a problem hiding this comment.
Yep, in this case the cons were clearly outbalancing the pros.
gleocadie
reviewed
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Describe a new build system to be implemented in libdatadog.
Motivation
Improve current the current one so it's less error prone, more maintainable and cand handle features as well as versioning.