[crashtracker] Build static binary#581
Merged
Merged
Conversation
rochdev
approved these changes
Aug 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
- Coverage 71.27% 71.26% -0.01%
==========================================
Files 219 220 +1
Lines 29918 29921 +3
==========================================
Hits 21323 21323
- Misses 8595 8598 +3
|
BenchmarksComparisonBenchmark execution time: 2024-08-06 20:35:04 Comparing candidate commit a2103c2 in PR branch Found 1 performance improvements and 4 performance regressions! Performance is the same for 37 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Builds a static binary for the crashtracker
Motivation
Request from Node.
Additional Notes
The binary is statically linked, and hence much larger than the dynamically linked C binary we currently generate. If possible, using that one will save binary size.
How to test the change?
Describe here in detail how the change can be validated.