Use append() for writing telemetry lock to file#585
Merged
Conversation
Otherwise we see spurious race conditions where the file is opened twice and one thread is overwriting to the start of the file. And lock cbindgen version for CI.
BenchmarksComparisonBenchmark execution time: 2024-08-12 15:44:34 Comparing candidate commit cc052c7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |
bantonsson
approved these changes
Aug 12, 2024
| ARG CARGO_NET_RETRY | ||
| ENV CARGO_NET_RETRY="${CARGO_NET_RETRY}" | ||
| RUN cargo install cbindgen && cargo install bindgen-cli --locked && rm -rf /root/.cargo/registry /root/.cargo/git | ||
| RUN cargo install cbindgen --version "^0.26" && cargo install bindgen-cli --locked && rm -rf /root/.cargo/registry /root/.cargo/git |
Contributor
There was a problem hiding this comment.
Should this specify a version for bindgen-cli?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
=======================================
Coverage 71.26% 71.27%
=======================================
Files 220 220
Lines 29924 29929 +5
=======================================
+ Hits 21326 21331 +5
Misses 8598 8598
|
hoolioh
pushed a commit
that referenced
this pull request
Aug 21, 2024
Otherwise we see spurious race conditions where the file is opened twice and one thread is overwriting to the start of the file. And lock cbindgen version for CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we see spurious race conditions where the file is opened twice and one thread is overwriting to the start of the file.
And lock cbindgen version for CI.