You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a tiny bytes::Bytes like implementation for having multiple byte slices pointing into the same slice.
Motivation
The implementation in bytes::Bytes does not allow us to use the mapped memory types in the ipc crate, and implementing support for such types in the original crate is a not an option, since it is non trivial and there is a large amount of functionality that doesn't map well to the mapped memory.
The reason will be displayed to describe this comment to others. Learn more.
I suppose we can do that. I suppose the overhead in size is minimal a couple bytes, which are likely anyway within padding (the struct is 32 bytes, and system allocator will give you 16 byte aligned memory...)
This is the PR for the proptest dependency changes that avoids affecting the benchmarks proptest-rs/proptest#499
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a tiny
bytes::Byteslike implementation for having multiple byte slices pointing into the same slice.Motivation
The implementation in
bytes::Bytesdoes not allow us to use the mapped memory types in theipccrate, and implementing support for such types in the original crate is a not an option, since it is non trivial and there is a large amount of functionality that doesn't map well to the mapped memory.Additional Notes
Jira ticket: APMS-1330
How to test the change?
There are tests.