Fix log file and disable LSAN usage in sidecar#602
Merged
Merged
Conversation
Contributor
bwoebi
commented
Aug 28, 2024
- Sidecar will leak some global structures, using LSAN there would either require an extensive suppressions list. For now we just opt to disable it. This avoids false positives in our testing we have to manually detect and ignore.
- Using an invalid log file should simply avoid sending it to the sidecar completely instead of failing there again, preventing two log messages for the same issue.
- Use _exit(0) instead of regular exit(0) when daemonizing to avoid sideeffects from atexit() handlers inherited from forking.
Like leak sanitizer running here; we definitely do not have cleaned up anything at this point.
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
- Coverage 72.84% 72.83% -0.01%
==========================================
Files 243 243
Lines 34681 34683 +2
==========================================
Hits 25263 25263
- Misses 9418 9420 +2
|
iamluc
approved these changes
Aug 28, 2024
BenchmarksComparisonBenchmark execution time: 2024-08-29 15:13:08 Comparing candidate commit 2734124 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |
bantonsson
reviewed
Aug 29, 2024
bantonsson
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.