Add benchmark for SpanConcentrator#603
Merged
VianneyRuhlmann merged 4 commits intoSep 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
=======================================
Coverage 72.88% 72.88%
=======================================
Files 245 245
Lines 34951 34951
=======================================
Hits 25473 25473
Misses 9478 9478
|
BenchmarksComparisonBenchmark execution time: 2024-09-04 11:38:49 Comparing candidate commit 56c8802 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
bantonsson
approved these changes
Aug 29, 2024
Contributor
bantonsson
left a comment
There was a problem hiding this comment.
LGTM Only one comment about benchmark name.
hoolioh
approved these changes
Aug 29, 2024
a2e8725 to
e04263d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add benchmark to concentrator to allow future otpimizations
Motivation
The concentrator is lacking some optimizations, this will make it easier to evaluate improvement.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.