Require docs on all public things in data-pipeline#614
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 73.06% 73.17% +0.11%
==========================================
Files 252 252
Lines 35959 35959
==========================================
+ Hits 26274 26314 +40
+ Misses 9685 9645 -40
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2024-09-09 19:04:45 Comparing candidate commit 66975a4 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics. scenario:credit_card/is_card_number_no_luhn/ 378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
ekump
approved these changes
Sep 9, 2024
VianneyRuhlmann
approved these changes
Sep 10, 2024
hoolioh
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Require docs on all public things in data-pipeline. Add docs for anywhere this wasn't already true.
Motivation
Docs are valuable for us and for others working in this repository.
How to test the change?
N/A