fix: GLS slot not cleaned up after goroutine exits#232
Merged
Conversation
The GLS slot was not reset to nil when the goroutine exits, causing the old context to be re-used whenever the g object was recycled from the free list.
…erly-manage-gls-slot # Conflicts: # internal/injector/builtin/generated.go
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 61.82% 61.82%
=======================================
Files 93 93
Lines 5027 5027
=======================================
Hits 3108 3108
Misses 1592 1592
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 task
eliottness
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Specifically
nilout the GLS slot when the goroutine exits, so that the underlying map can be GC'd and it is not incorrectly re-used by the next goroutine if that g is recycled from the gf list.Motivation
The GLS slot was not reset to nil when the goroutine exits, causing the old context to be re-
used whenever the g object was recycled from the free list.