Skip to content

feat(internal/injector): add method-call join point#829

Merged
rarguelloF merged 8 commits into
mainfrom
rarguelloF/method-call
May 19, 2026
Merged

feat(internal/injector): add method-call join point#829
rarguelloF merged 8 commits into
mainfrom
rarguelloF/method-call

Conversation

@rarguelloF
Copy link
Copy Markdown
Contributor

@rarguelloF rarguelloF commented May 5, 2026

Add new method-call join point that matches calls by the receiver's resolved type. Example:

  method-call:
    receiver: "go.uber.org/zap.Logger" # fully qualified type name (package import path + type name) without a pointer sigil.                                                                                                                                                                                                                           
    name: Info # the method to match.
    match: any # possible values are: any (default), pointer-only, or value-only.                                                                                                                                                                                                                                                              

Needed for DataDog/dd-trace-go#4729

@github-actions github-actions Bot added the conventional-commit/feat Feature work label May 5, 2026
@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented May 5, 2026

🎯 Code Coverage (details)
Patch Coverage: 71.05%
Overall Coverage: 69.01%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 65a300e | Docs | Datadog PR Page | Give us feedback!

@rarguelloF rarguelloF marked this pull request as ready for review May 11, 2026 11:12
@rarguelloF rarguelloF requested a review from a team as a code owner May 11, 2026 11:12
Comment thread internal/injector/aspect/join/method_call_test.go Outdated
Comment thread internal/injector/aspect/join/method_call.go
@rarguelloF rarguelloF requested a review from darccio May 18, 2026 10:38
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 73.86364% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.77%. Comparing base (e061d12) to head (65a300e).
⚠️ Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
internal/injector/aspect/join/method_call.go 73.86% 19 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   65.72%   70.77%   +5.05%     
==========================================
  Files         113      118       +5     
  Lines        7926     6990     -936     
==========================================
- Hits         5209     4947     -262     
+ Misses       2192     1469     -723     
- Partials      525      574      +49     
Components Coverage Δ
Generators 83.23% <ø> (+2.98%) ⬆️
Instruments ∅ <ø> (∅)
Go Driver 75.58% <65.38%> (-0.23%) ⬇️
Toolexec Driver 74.78% <100.00%> (+7.25%) ⬆️
Aspects 76.76% <74.64%> (+4.85%) ⬆️
Injector 77.09% <75.66%> (+4.30%) ⬆️
Job Server 71.22% <55.55%> (+5.30%) ⬆️
Other 70.77% <66.23%> (+5.05%) ⬆️
Files with missing lines Coverage Δ
internal/injector/aspect/join/method_call.go 73.86% <73.86%> (ø)

... and 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rarguelloF rarguelloF added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 920342e May 19, 2026
77 checks passed
@rarguelloF rarguelloF deleted the rarguelloF/method-call branch May 19, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants