v5.12.0 #244
Merged
v5.12.0 #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szegedi
commented
Oct 29, 2025
szegedi
commented
- Update for Node.js 25 (Update for Node.js 25 #241)
- fix: use normalized path consistently in getMappingInfo (fix: use normalized path consistently in getMappingInfo #242)
* Expand version support to 25, disable benchmarks for now * V8 shipped with Node 25 adds HandleScopeData to visible internals. We only need to define it on Node 24. * Temporary: Remove -Werror until Node 25 stops emitting NAPI_EXPERIMENTAL-related warning * Update macOS compilation settings * fix another set-output deprecation
The getMappingInfo method was normalizing the path for the has() check but then using the non-normalized path for the get() call. This could cause lookups to fail when the normalized and non-normalized paths differ (e.g., on Windows with different path separators). This fix stores the normalized path in a variable and uses it consistently for both the has() and get() operations. Signed-off-by: Stephen Belanger <admin@stephenbelanger.com>
Overall package sizeSelf size: 1.7 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
nsavoire
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.