Skip to content

Add Node.js v25 to benchmarks #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IlyasShabi merged 1 commit into from
May 18, 2026
+2 −2
Merged

Add Node.js v25 to benchmarks #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitlab/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ benchmarks:
- MAJOR_NODE_VERSION: 20
- MAJOR_NODE_VERSION: 22
- MAJOR_NODE_VERSION: 24
# TODO: Re-enable this once support for Node 25 is merged on main
# - MAJOR_NODE_VERSION: 25
- MAJOR_NODE_VERSION: 25
artifacts:
name: "reports"
paths:
Expand Down
1 change: 1 addition & 0 deletions benchmark/sirun/runall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ if [ -n "${MAJOR_NODE_VERSION:-}" ]; then
source "${NVM_DIR:-usr/local/nvm}/nvm.sh"
fi

nvm install "${MAJOR_NODE_VERSION}"
Copy link
Copy Markdown
Author

@IlyasShabi IlyasShabi May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this step since benchmark action failed:

You need to run `nvm install 25` to install and use it.

https://gitlab.ddbuild.io/DataDog/apm-reliability/pprof-nodejs/-/jobs/1690230397

nvm use "${MAJOR_NODE_VERSION}"

pushd ../../
Expand Down
Loading